Source/devtools/front_end/sources/JavaScriptCompiler.js - Issue 1264133002: Devtools: [WIP] Implement enhanced devtools extension language APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/sources/JavaScriptCompiler.js

Issue 1264133002: Devtools: [WIP] Implement enhanced devtools extension language APIs Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Small cleanups - prefer URIs to contentURLs, revert protocol unifications, remove lambdas Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/sources/AdvancedSearchView.js ('k') | Source/devtools/front_end/sources/JavaScriptSourceFrame.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/sources/JavaScriptCompiler.js

diff --git a/Source/devtools/front_end/sources/JavaScriptCompiler.js b/Source/devtools/front_end/sources/JavaScriptCompiler.js

index 23850b492da0bdaae247b5c5565c4b9e681f907d..a4e2f305ee4be2d84b9ddb2d86f8989e9915fd06 100644

--- a/Source/devtools/front_end/sources/JavaScriptCompiler.js

+++ b/Source/devtools/front_end/sources/JavaScriptCompiler.js

@@ -70,7 +70,8 @@ WebInspector.JavaScriptCompiler.prototype = {

}

if (!exceptionDetails)

return;

- var message = new WebInspector.SourceFrameMessage(exceptionDetails.text, WebInspector.SourceFrameMessage.Level.Error, exceptionDetails.line - 1, exceptionDetails.column + 1);

+ var location = {line: exceptionDetails.line - 1, column: exceptionDetails.column + 1};

+ var message = new WebInspector.SourceFrameMessage(exceptionDetails.text, WebInspector.SourceFrameMessage.Level.Error, location, location);

this._sourceFrame.addMessageToSource(message);

this._compilationFinishedForTest();

}