Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1700)

Unified Diff: Source/devtools/front_end/components/ExecutionContextSelector.js

Issue 1264133002: Devtools: [WIP] Implement enhanced devtools extension language APIs Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Small cleanups - prefer URIs to contentURLs, revert protocol unifications, remove lambdas Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/common/TextUtils.js ('k') | Source/devtools/front_end/components/SearchData.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/components/ExecutionContextSelector.js
diff --git a/Source/devtools/front_end/components/ExecutionContextSelector.js b/Source/devtools/front_end/components/ExecutionContextSelector.js
index d4ffff7af2acf8d15ee212f8d58a4a75180a63b2..08a44e38e9617ef8daf7ecfd2000d5d943eb1355 100644
--- a/Source/devtools/front_end/components/ExecutionContextSelector.js
+++ b/Source/devtools/front_end/components/ExecutionContextSelector.js
@@ -148,11 +148,13 @@ WebInspector.ExecutionContextSelector.prototype = {
/**
* @param {!Element} proxyElement
+ * @param {string} text
+ * @param {number} cursorOffset
* @param {!Range} wordRange
* @param {boolean} force
* @param {function(!Array.<string>, number=)} completionsReadyCallback
*/
-WebInspector.ExecutionContextSelector.completionsForTextPromptInCurrentContext = function(proxyElement, wordRange, force, completionsReadyCallback)
+WebInspector.ExecutionContextSelector.completionsForTextPromptInCurrentContext = function(proxyElement, text, cursorOffset, wordRange, force, completionsReadyCallback)
{
var executionContext = WebInspector.context.flavor(WebInspector.ExecutionContext);
if (!executionContext) {
@@ -170,5 +172,5 @@ WebInspector.ExecutionContextSelector.completionsForTextPromptInCurrentContext =
expressionString = expressionString.substr(pos + 1);
var prefix = wordRange.toString();
- executionContext.completionsForExpression(expressionString, prefix, force, completionsReadyCallback);
+ executionContext.completionsForExpression(expressionString, text, cursorOffset, prefix, force, completionsReadyCallback);
}
« no previous file with comments | « Source/devtools/front_end/common/TextUtils.js ('k') | Source/devtools/front_end/components/SearchData.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698