Source/devtools/front_end/ui/TextPrompt.js - Issue 1264133002: Devtools: [WIP] Implement enhanced devtools extension language APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/ui/TextPrompt.js

Issue 1264133002: Devtools: [WIP] Implement enhanced devtools extension language APIs Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Modify override dropdown to apply to console completions & transpile Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/ui/SuggestBox.js ('K') | « Source/devtools/front_end/ui/SuggestBox.js ('k') | Source/devtools/front_end/ui/module.json » ('j') | Source/devtools/front_end/ui/module.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/ui/TextPrompt.js

diff --git a/Source/devtools/front_end/ui/TextPrompt.js b/Source/devtools/front_end/ui/TextPrompt.js

index 0734a53893b67189014a7d98df5db2599609428d..c6456c1a4e3b57bc84598531bd8e82ad33a46676 100644

--- a/Source/devtools/front_end/ui/TextPrompt.js

+++ b/Source/devtools/front_end/ui/TextPrompt.js

@@ -31,7 +31,7 @@

* @constructor

* @extends {WebInspector.Object}

* @implements {WebInspector.SuggestBoxDelegate}

- * @param {function(!Element, !Range, boolean, function(!Array.<string>, number=))} completions

+ * @param {function(!Element, string, number, !Range, boolean, function(!Array.<string>, number=))} completions

pfeldman 2015/08/13 21:15:47 This is worth a separate patch.

wes 2015/08/14 00:55:05 Adding extra parameters to the completions delegat

* @param {string=} stopCharacters

WebInspector.TextPrompt = function(completions, stopCharacters)

@@ -400,7 +400,7 @@ WebInspector.TextPrompt.prototype = {

var wordPrefixRange = selectionRange.startContainer.rangeOfWord(selectionRange.startOffset, this._completionStopCharacters, this._element, "backward");

this._waitingForCompletions = true;

- this._loadCompletions(/** @type {!Element} */ (this._proxyElement), wordPrefixRange, force || false, this._completionsReady.bind(this, selection, wordPrefixRange, !!reverse));

+ this._loadCompletions(/** @type {!Element} */ (this._proxyElement), this.text(), selectionRange.startOffset, wordPrefixRange, force || false, this._completionsReady.bind(this, selection, wordPrefixRange, !!reverse));

disableDefaultSuggestionForEmptyInput: function()

@@ -762,7 +762,7 @@ WebInspector.TextPrompt.prototype = {

/**

* @constructor

* @extends {WebInspector.TextPrompt}

- * @param {function(!Element, !Range, boolean, function(!Array.<string>, number=))} completions

+ * @param {function(!Element, string, number, !Range, boolean, function(!Array.<string>, number=))} completions

* @param {string=} stopCharacters

WebInspector.TextPromptWithHistory = function(completions, stopCharacters)