Devtools: [WIP] Implement enhanced devtools extension language APIs

Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 938 matching lines @@
     {
         this._mimeType = mimeType;
         if (this._hasLongLines())
             this._enableLongLinesMode();
         else
             this._disableLongLinesMode();
         this._updateCodeMirrorMode();
     },
 
     /**
+     * @return {string}
+     */
+    getMimeType: function() {

[pfeldman, 2015/08/13 21:15:47]

no get prefixes in Blink please!

[wes, 2015/08/14 00:55:05]

Understood! Is there a lint rule for this? :P

+        return this._mimeType;
+    },
+
+    /**
      * @param {boolean} readOnly
      */
     setReadOnly: function(readOnly)
     {
         this.element.classList.toggle("CodeMirror-readonly", readOnly);
         this._codeMirror.setOption("readOnly", readOnly);
     },
 
     /**
      * @return {boolean}
@@ skipping 82 matching lines @@
     },
 
     _gutterClick: function(instance, lineNumber, gutter, event)
     {
         this.dispatchEventToListeners(WebInspector.CodeMirrorTextEditor.Events.GutterClick, { lineNumber: lineNumber, event: event });
     },
 
     _contextMenu: function(event)
     {
         var contextMenu = new WebInspector.ContextMenu(event);
+        event.consume(true); //Consume event now to prevent document from handling the async menu
         var target = event.target.enclosingNodeOrSelfWithClass("CodeMirror-gutter-elt");
+        var prom;
         if (target)
-            this._delegate.populateLineGutterContextMenu(contextMenu, parseInt(target.textContent, 10) - 1);
+            prom = this._delegate.populateLineGutterContextMenu(contextMenu, parseInt(target.textContent, 10) - 1);
         else {
             var textSelection = this.selection();
-            this._delegate.populateTextAreaContextMenu(contextMenu, textSelection.startLine, textSelection.startColumn);
+            prom = this._delegate.populateTextAreaContextMenu(contextMenu, textSelection.startLine, textSelection.startColumn);
         }
-        contextMenu.appendApplicableItems(this);
-        contextMenu.show();
+
+        prom.then(showAsync, showAsync);

[wes, 2015/08/14 00:55:05]

By the way - showing the context menu async seems flaky on the c++ side.

Random assertion violations seem to happen if one context menu attempts to get
drawn while another is, or if the JS tries to draw the menu twice. I hunted down
assertion violations many a time before I added the `event.consume(true);`
above.

+        var _this = this;
+        function showAsync() {
+            contextMenu.appendApplicableItems(_this);
+            contextMenu.show();
+        }
     },
 
     /**
      * @param {number} lineNumber
      * @param {boolean} disabled
      * @param {boolean} conditional
      */
     addBreakpoint: function(lineNumber, disabled, conditional)
     {
         if (lineNumber < 0 || lineNumber >= this._codeMirror.lineCount())
@@ skipping 450 matching lines @@
 
     /**
      * @return {number}
      */
     get linesCount()
     {
         return this._codeMirror.lineCount();
     },
 
     /**
+     * @return {?string}
+     */
+    get url()
+    {
+        return this._url;
+    },
+
+    /**
      * @param {number} line
      * @param {string} name
      * @param {?Object} value
      */
     setAttribute: function(line, name, value)
     {
         if (line < 0 || line >= this._codeMirror.lineCount())
             return;
         var handle = this._codeMirror.getLineHandle(line);
         if (handle.attributes === undefined) handle.attributes = {};
@@ skipping 607 matching lines @@
     /**
      * @param {number} lineNumber
      */
     scrollChanged: function(lineNumber) { },
 
     editorFocused: function() { },
 
     /**
      * @param {!WebInspector.ContextMenu} contextMenu
      * @param {number} lineNumber
+     * @return {!Promise}
      */
     populateLineGutterContextMenu: function(contextMenu, lineNumber) { },
 
     /**
      * @param {!WebInspector.ContextMenu} contextMenu
      * @param {number} lineNumber
      * @param {number} columnNumber
+     * @return {!Promise}
      */
     populateTextAreaContextMenu: function(contextMenu, lineNumber, columnNumber) { },
 
     /**
      * @param {?WebInspector.TextRange} from
      * @param {?WebInspector.TextRange} to
      */
     onJumpToPosition: function(from, to) { }
 }
 
@@ skipping 66 matching lines @@
 WebInspector.CodeMirrorMimeMode = function()
 {
 }
 
 WebInspector.CodeMirrorMimeMode.prototype = {
     /**
      * @param {!Runtime.Extension} extension
      */
     install: function(extension) { }
 }