Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: sql/connection_unittest.cc

Issue 1264123002: HistogramTester::GetHistogramSamplesSinceCreation never returns null (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sql tests simplified Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sql/connection_unittest.cc
diff --git a/sql/connection_unittest.cc b/sql/connection_unittest.cc
index c7d9080c8f904a0a83195c0589dd7c61b5c649fd..df35dd10d08233effde856ce9608d24fed37541f 100644
--- a/sql/connection_unittest.cc
+++ b/sql/connection_unittest.cc
@@ -1194,13 +1194,13 @@ TEST_F(SQLConnectionTest, TimeQuery) {
EXPECT_EQ(11, samples->sum());
samples = tester.GetHistogramSamplesSinceCreation(kUpdateTime);
- EXPECT_TRUE(!samples || samples->sum() == 0);
+ EXPECT_EQ(0, samples->sum());
samples = tester.GetHistogramSamplesSinceCreation(kCommitTime);
- EXPECT_TRUE(!samples || samples->sum() == 0);
+ EXPECT_EQ(0, samples->sum());
samples = tester.GetHistogramSamplesSinceCreation(kAutoCommitTime);
- EXPECT_TRUE(!samples || samples->sum() == 0);
+ EXPECT_EQ(0, samples->sum());
}
// Autocommit update allocates time to QueryTime, UpdateTime, and
@@ -1237,7 +1237,7 @@ TEST_F(SQLConnectionTest, TimeUpdateAutocommit) {
EXPECT_EQ(11, samples->sum());
samples = tester.GetHistogramSamplesSinceCreation(kCommitTime);
- EXPECT_TRUE(!samples || samples->sum() == 0);
+ EXPECT_EQ(0, samples->sum());
samples = tester.GetHistogramSamplesSinceCreation(kAutoCommitTime);
ASSERT_TRUE(samples);
@@ -1296,7 +1296,7 @@ TEST_F(SQLConnectionTest, TimeUpdateTransaction) {
EXPECT_EQ(101, samples->sum());
samples = tester.GetHistogramSamplesSinceCreation(kAutoCommitTime);
- EXPECT_TRUE(!samples || samples->sum() == 0);
+ EXPECT_EQ(0, samples->sum());
}
} // namespace
« base/test/histogram_tester_unittest.cc ('K') | « base/test/histogram_tester_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698