Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Issue 1264053002: CFI: Add a death test. (Closed)

Created:
5 years, 4 months ago by pcc1
Modified:
5 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CFI: Add a death test. BUG=464797 R=thakis@chromium.org Committed: https://crrev.com/0736491d71147860f78d6d82a71b259fba3f6148 Cr-Commit-Position: refs/heads/master@{#341235}

Patch Set 1 #

Patch Set 2 : Fix build config #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M base/tools_sanity_unittest.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M build/common.gypi View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
pcc1
5 years, 4 months ago (2015-07-30 20:48:31 UTC) #1
Nico
lgtm
5 years, 4 months ago (2015-07-30 21:41:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264053002/1
5 years, 4 months ago (2015-07-30 21:42:14 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/101784) android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 4 months ago (2015-07-30 21:47:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264053002/20001
5 years, 4 months ago (2015-07-30 22:44:09 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-31 00:19:13 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 00:20:06 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0736491d71147860f78d6d82a71b259fba3f6148
Cr-Commit-Position: refs/heads/master@{#341235}

Powered by Google App Engine
This is Rietveld 408576698