customtabs: Add throttling to mayLaunchUrl.

customtabs: Add throttling to mayLaunchUrl.

This adds a simple throttling policy for mayLaunchUrl(). Each
accepted mayLaunchUrl() request increases the delay before accepting the
next one. Initial delay is 100ms, and the maximum delay is 10s. Waiting
at least 2*current_interval resets the interval to 100ms, as well as
correctly predicting the destination URL.

Note that the tracking is done by UID (~app) instead of session, as a
misbehaving application can open a large number of sessions.

BUG=514825
Committed: https://crrev.com/da510f4184d5879d34138e239ba080f7159e3ebd
Cr-Commit-Position: refs/heads/master@{#342329}

[Benoit L, 2015-07-31 13:54:49]

lizeb@chromium.org changed reviewers:
+ ianwen@chromium.org, yusufo@chromium.org

[Benoit L, 2015-08-05 08:45:02]

On 2015/07/31 13:54:50, Benoit L wrote:

ping :-)

[Ian Wen, 2015-08-05 18:35:17]

https://codereview.chromium.org/1264013005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
(right):

https://codereview.chromium.org/1264013005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java:99:
* - Initially, one prediction is allowed every 100ms
The description does not match the actual code below. I think the policy is:

1. If client does not wait more than mDelayMs, decline request.
2. If client waits for more than mDelayMs but less than 2*mDelayMs, accept
request but double mDelayMs.
3. If client waits for more than 2*mDelayMs, accecpt request and reset mDelayMs.

Does the above look correct?

[Benoit L, 2015-08-06 14:59:07]

https://codereview.chromium.org/1264013005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
(right):

https://codereview.chromium.org/1264013005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java:99:
* - Initially, one prediction is allowed every 100ms
On 2015/08/05 18:35:17, Ian Wen wrote:
> The description does not match the actual code below. I think the policy is:
> 
> 1. If client does not wait more than mDelayMs, decline request.
> 2. If client waits for more than mDelayMs but less than 2*mDelayMs, accept
> request but double mDelayMs.
> 3. If client waits for more than 2*mDelayMs, accecpt request and reset
mDelayMs.
> 
> Does the above look correct?

It is, but I don't really see how the current comment is wrong. :-)
Updated.

[Yusuf, 2015-08-06 15:04:01]

lgtm

[Benoit L, 2015-08-06 15:05:48]

The CQ bit was checked by lizeb@chromium.org

[Benoit L, 2015-08-06 15:05:48]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org
Link to the patchset: https://codereview.chromium.org/1264013005/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-08-06 15:06:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1264013005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1264013005/40001

[commit-bot: I haz the power, 2015-08-06 16:46:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-06 16:46:32]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[Benoit L, 2015-08-07 09:41:10]

The CQ bit was checked by lizeb@chromium.org

[Benoit L, 2015-08-07 09:41:10]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org
Link to the patchset: https://codereview.chromium.org/1264013005/#ps60001
(title: "Fix test.")

[commit-bot: I haz the power, 2015-08-07 09:41:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1264013005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1264013005/60001

[commit-bot: I haz the power, 2015-08-07 10:19:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-08-07 10:20:10]

Patchset 4 (id:??) landed as
https://crrev.com/da510f4184d5879d34138e239ba080f7159e3ebd
Cr-Commit-Position: refs/heads/master@{#342329}