Chromium Code Reviews

Issue 1263983002: Revert of Roll third_party/custom_tabs_client (Closed)

Created:
5 years, 4 months ago by timvolodine
Modified:
5 years, 4 months ago
Reviewers:
Ian Wen, Yusuf
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll third_party/custom_tabs_client (patchset #1 id:1 of https://codereview.chromium.org/1254383014/) Reason for revert: speculative revert, prevents clank roll downstream, see crbug.com/515457 Original issue's description: > Roll third_party/custom_tabs_client > > Roll from 6bae8bf337d5c51184c0c01f5baca3e0858 to > 19d5cb35bece11876e8f34c17c6fdfd9bad. > > BUG=510083 > > Committed: https://crrev.com/dc731ce3111a8d4f316e478601707cc33e70e542 > Cr-Commit-Position: refs/heads/master@{#341048} TBR=yusufo@chromium.org,ianwen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=510083 Committed: https://crrev.com/66d3e303ded89c565e8fb33d8000044cdcf2b8c1 Cr-Commit-Position: refs/heads/master@{#341100} Committed: https://crrev.com/2437a647519eaa88abb281af73d3243a3d7a97e4 Cr-Commit-Position: refs/heads/master@{#341108}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+1 line, -1 line)
M DEPS View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 10 (1 generated)
timvolodine
Created Revert of Roll third_party/custom_tabs_client
5 years, 4 months ago (2015-07-30 11:54:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263983002/1
5 years, 4 months ago (2015-07-30 11:55:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-30 11:55:36 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/66d3e303ded89c565e8fb33d8000044cdcf2b8c1 Cr-Commit-Position: refs/heads/master@{#341100}
5 years, 4 months ago (2015-07-30 11:56:21 UTC) #4
timvolodine
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1252393003/ by timvolodine@chromium.org. ...
5 years, 4 months ago (2015-07-30 12:48:27 UTC) #5
timvolodine
On 2015/07/30 12:48:27, timvolodine wrote: > A revert of this CL (patchset #1 id:1) has ...
5 years, 4 months ago (2015-07-30 13:52:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263983002/1
5 years, 4 months ago (2015-07-30 13:54:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-30 13:54:50 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 13:55:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2437a647519eaa88abb281af73d3243a3d7a97e4
Cr-Commit-Position: refs/heads/master@{#341108}

Powered by Google App Engine