runtime/lib/math_patch.dart - Issue 1263963003: Fix some TODOs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/math_patch.dart

Issue 1263963003: Fix some TODOs (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/lib/math_patch.dart

diff --git a/runtime/lib/math_patch.dart b/runtime/lib/math_patch.dart

index 45eb5ef7037e5d78fc1e7cf638e444fa50c2bb05..5942078f8a90539bfd526a110aba9d7a63352592 100644

--- a/runtime/lib/math_patch.dart

+++ b/runtime/lib/math_patch.dart

@@ -114,8 +114,6 @@ class _Random implements Random {

void _nextState() native "Random_nextState";

int nextInt(int max) {

- // TODO(srdjan): Remove the 'limit' check once optimizing comparison of

- // Smi-s with Mint constants.

final limit = 0x3FFFFFFF;

if (max <= 0 || ((max > limit) && (max > _POW2_32))) {

throw new ArgumentError("max must be positive and < 2^32:"

« no previous file with comments | « runtime/lib/integers.dart ('k') | runtime/lib/string_buffer_patch.dart » ('j') | no next file with comments »