Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1263953002: Eagerly finalize V8AbstractEventListeners. (Closed)

Created:
5 years, 4 months ago by sof
Modified:
5 years, 4 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, vivekg, blink-reviews-bindings_chromium.org, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Eagerly finalize V8AbstractEventListeners. The listener's wrapper needs to be promptly cleared so as to prevent untidy accesses to a poisoned heap by v8's GC if the listener is instead lazily swept & finalized. R=haraken BUG=491488 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199721

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M Source/bindings/core/v8/V8AbstractEventListener.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sof
please take a look. Addresses flaky crashers, https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Oilpan_ASAN/3135/layout-test-results/results.html
5 years, 4 months ago (2015-07-30 07:41:14 UTC) #2
haraken
Thanks for digging into the flakiness. LGTM.
5 years, 4 months ago (2015-07-30 07:54:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263953002/1
5 years, 4 months ago (2015-07-30 08:04:00 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 08:42:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199721

Powered by Google App Engine
This is Rietveld 408576698