Unified Desktop: Support 2xDSF display

Unified Desktop: Support 2xDSF display

* Moved and renamed accelerator functions for UI scaling as
it now handles resolution change. The term "zoom" would be  more appropriate as it describe the feature not how it's implemented.

* Cleanup the obsolete ui scaling code for unified desktop in RootWindowTransformers

BUG=514877
TEST=covered by unit tests. manual.

Committed: https://crrev.com/af6e857fabbb950795ad49a9d3a992148fcddf61
Cr-Commit-Position: refs/heads/master@{#341172}

[oshima, 2015-07-29 19:27:49]

Patchset #1 (id:1) has been deleted

[oshima, 2015-07-29 19:28:51]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-29 19:29:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1263853002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1263853002/20001

[oshima, 2015-07-29 20:20:52]

oshima@chromium.org changed reviewers:
+ mukai@chromium.org

[oshima, 2015-07-29 20:20:52]

https://codereview.chromium.org/1263853002/diff/20001/ash/display/unified_mou...
File ash/display/unified_mouse_warp_controller_unittest.cc (right):

https://codereview.chromium.org/1263853002/diff/20001/ash/display/unified_mou...
ash/display/unified_mouse_warp_controller_unittest.cc:107:
EXPECT_FALSE(TestIfMouseWarpsAt(gfx::Point(11, 11)));
TestIfMouseWarp currently doesn't work with dsf x. I'm working on it.

https://codereview.chromium.org/1263853002/diff/20001/ash/host/ash_window_tre...
File ash/host/ash_window_tree_host_unified.cc (left):

https://codereview.chromium.org/1263853002/diff/20001/ash/host/ash_window_tre...
ash/host/ash_window_tree_host_unified.cc:32:
dst_root_->GetHost()->GetRootTransform());
Event transform is handled in WindowEventDispatcher, so this wasn't necessary.

[commit-bot: I haz the power, 2015-07-29 20:24:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-29 20:24:22]

Dry run: This issue passed the CQ dry run.

[Jun Mukai, 2015-07-29 21:26:28]

https://codereview.chromium.org/1263853002/diff/20001/ash/accelerators/accele...
File ash/accelerators/accelerator_commands.cc (right):

https://codereview.chromium.org/1263853002/diff/20001/ash/accelerators/accele...
ash/accelerators/accelerator_commands.cc:102: bool
IsInternalDisplayZoomEnabled() {
Be sure to appear in the same order in .h and .cc files.

https://codereview.chromium.org/1263853002/diff/20001/ash/display/display_man...
File ash/display/display_manager.cc (right):

https://codereview.chromium.org/1263853002/diff/20001/ash/display/display_man...
ash/display/display_manager.cc:1123: default_device_scale_factor =
info.device_scale_factor();
This means that if two displays are in the same height (i.e. in the same
resolution) but their DSF are different, the default one is the
device_scale_factor which happens to appear the first.
Considering HD Chromebook + external display or multiple 4K display
concatenations, I think it might be better to choose the lower-DSF as the
default.

https://codereview.chromium.org/1263853002/diff/20001/ash/display/display_man...
ash/display/display_manager.cc:1142: std::make_pair(info.device_scale_factor(),
scale));
Also, can we add a case of dsf=1.0 as an option?

[oshima, 2015-07-30 01:17:10]

Patchset #2 (id:40001) has been deleted

[oshima, 2015-07-30 01:33:32]

https://codereview.chromium.org/1263853002/diff/20001/ash/accelerators/accele...
File ash/accelerators/accelerator_commands.cc (right):

https://codereview.chromium.org/1263853002/diff/20001/ash/accelerators/accele...
ash/accelerators/accelerator_commands.cc:102: bool
IsInternalDisplayZoomEnabled() {
On 2015/07/29 21:26:28, Jun Mukai wrote:
> Be sure to appear in the same order in .h and .cc files.

Done.

https://codereview.chromium.org/1263853002/diff/20001/ash/display/display_man...
File ash/display/display_manager.cc (right):

https://codereview.chromium.org/1263853002/diff/20001/ash/display/display_man...
ash/display/display_manager.cc:1123: default_device_scale_factor =
info.device_scale_factor();
On 2015/07/29 21:26:28, Jun Mukai wrote:
> This means that if two displays are in the same height (i.e. in the same
> resolution) but their DSF are different, the default one is the
> device_scale_factor which happens to appear the first.
> Considering HD Chromebook + external display or multiple 4K display
> concatenations, I think it might be better to choose the lower-DSF as the
> default.

Per offline discussion, changed to use the 1st or internal display as a default.

https://codereview.chromium.org/1263853002/diff/20001/ash/display/display_man...
ash/display/display_manager.cc:1142: std::make_pair(info.device_scale_factor(),
scale));
On 2015/07/29 21:26:28, Jun Mukai wrote:
> Also, can we add a case of dsf=1.0 as an option?

Let's wait for user's feedback. My guess is that users want other resolutions
rather than 1.0dsf, but that should be easy to add.

[oshima, 2015-07-30 01:33:37]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-30 01:34:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1263853002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1263853002/80001

[commit-bot: I haz the power, 2015-07-30 02:17:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-30 02:17:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2015-07-30 05:50:23]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-30 05:51:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1263853002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1263853002/100001

[commit-bot: I haz the power, 2015-07-30 07:17:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-30 07:17:55]

Dry run: This issue passed the CQ dry run.

[Jun Mukai, 2015-07-30 17:11:12]

lgtm with a nit

https://codereview.chromium.org/1263853002/diff/100001/ash/display/display_ma...
File ash/display/display_manager.cc (right):

https://codereview.chromium.org/1263853002/diff/100001/ash/display/display_ma...
ash/display/display_manager.cc:88: std::vector<DisplayMode>::const_iterator
FindDisplayModeL(
I am not sure what is the benefit of defining this function -- at least it's
only used in FindDisplayMode(), so you can invoke std::find_if there.  Also the
body is just two-lines, not sure how beneficial is defining it.

[oshima, 2015-07-30 18:43:29]

https://codereview.chromium.org/1263853002/diff/100001/ash/display/display_ma...
File ash/display/display_manager.cc (right):

https://codereview.chromium.org/1263853002/diff/100001/ash/display/display_ma...
ash/display/display_manager.cc:88: std::vector<DisplayMode>::const_iterator
FindDisplayModeL(
On 2015/07/30 17:11:11, Jun Mukai wrote:
> I am not sure what is the benefit of defining this function -- at least it's
> only used in FindDisplayMode(), so you can invoke std::find_if there.  Also
the
> body is just two-lines, not sure how beneficial is defining it.

Thanks for the catch. I was going to clean up but apparently forgot it.
Done.

[oshima, 2015-07-30 18:43:40]

The CQ bit was checked by oshima@chromium.org

[oshima, 2015-07-30 18:43:40]

The patchset sent to the CQ was uploaded after l-g-t-m from mukai@chromium.org
Link to the patchset: https://codereview.chromium.org/1263853002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2015-07-30 18:43:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1263853002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1263853002/120001

[commit-bot: I haz the power, 2015-07-30 19:42:27]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2015-07-30 19:43:14]

Patchset 5 (id:??) landed as
https://crrev.com/af6e857fabbb950795ad49a9d3a992148fcddf61
Cr-Commit-Position: refs/heads/master@{#341172}