Issue 12638003: Replace hand-written JNI in fling_animator with generated bindings.

Issue 12638003: Replace hand-written JNI in fling_animator with generated bindings. (Closed)

Created:
7 years, 9 months ago by Yaron

Modified:
7 years, 9 months ago

Reviewers:
tony, bulach

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Replace hand-written JNI in fling_animator with generated bindings. Using generated bindings are safer, and we're trying to remove existing manual bindings. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187409

Total comments: 1

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -49 lines)			Patch
M	content/common/android/common_jni_registrar.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/DEPS	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/fling_animator_impl_android.h	View		2 chunks	+3 lines, -5 lines	0 comments	Download
M	webkit/glue/fling_animator_impl_android.cc	View		3 chunks	+25 lines, -44 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	1	2 chunks	+20 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

Yaron

I'm not sure if the registrar is at a low enough level in content_common. I ...

7 years, 9 months ago (2013-03-07 19:51:55 UTC) #1

tony

I defer this review to bulach. rubber stamp LGTM for webkit/

7 years, 9 months ago (2013-03-08 00:50:25 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/12638003/6001

7 years, 9 months ago (2013-03-11 18:52:13 UTC) #5

Message was sent while issue was closed.

Change committed as 187409