Issue 12638: Fixed uncanonicalization inconsistency.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12638: Fixed uncanonicalization inconsistency. (Closed)

Created:
12 years ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Fixed problem where the two lower-case sigmas would uncanonicalize to themselves and upper-case sigma, but upper-case sigma would uncanonicalize to just lower-case final sigma.

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -9 lines)			Patch
M	src/jsregexp.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/unicode.cc	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	test/cctest/test-regexp.cc	View	2 chunks	+20 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

I guess it LGTM. It would be nice to see the changes to unibrow, rather ...

12 years ago (2008-11-25 18:24:51 UTC) #2

Christian Plesner Hansen

12 years ago (2008-11-26 06:03:45 UTC) #3

I'll send the unibrow changes to review too.

http://codereview.chromium.org/12638/diff/1/4
File test/cctest/test-regexp.cc (right):

http://codereview.chromium.org/12638/diff/1/4#newcode1090
Line 1090: if (next_block + i == 880)
That was a mistake.

Expand Messages | Collapse Messages