Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1263773002: Pretenuring decision of outermost literal is propagated to inner literals. (Closed)

Created:
5 years, 4 months ago by Hannes Payer (out of office)
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Pretenuring decision of outermost literal is propagated to inner literals. Literals should stay together to simplify allocation folding. This CL takes the pretenuring information from the outermost literal and applies it to the inner liberals. BUG=chromium:514721 LOG=n R=mvstanton@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/aa84551622799c6c44b8ee60ea6c40405465177a

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M src/hydrogen.cc View 1 3 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Hannes Payer (out of office)
5 years, 4 months ago (2015-07-29 08:51:14 UTC) #2
mvstanton
Nice. Use site_context->top() and you won't have to pass the new parameter...
5 years, 4 months ago (2015-07-29 08:55:19 UTC) #3
Hannes Payer (out of office)
Thanks Michael, that makes it simpler! Done.
5 years, 4 months ago (2015-07-29 09:05:51 UTC) #4
mvstanton
Right on, LGTM.
5 years, 4 months ago (2015-07-29 09:19:18 UTC) #5
Hannes Payer (out of office)
5 years, 4 months ago (2015-07-29 09:56:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
aa84551622799c6c44b8ee60ea6c40405465177a (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698