Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 1263763008: Have ClientSocketPoolBase defriend base::RefCounted. (Closed)

Created:
5 years, 4 months ago by mmenke
Modified:
5 years, 4 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Have ClientSocketPoolBase defriend base::RefCounted. ClientSocketPoolBase was once refcounted, but they grew apart long ago. BUG=NONE Committed: https://crrev.com/41f22a78a5d385ece47256f1f5605b2029d8621a Cr-Commit-Position: refs/heads/master@{#341632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M net/socket/client_socket_pool_base.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mmenke
Perhaps not really worth the effort, but noticed this when I was looking for classes ...
5 years, 4 months ago (2015-08-03 20:48:24 UTC) #2
eroman
lgtm
5 years, 4 months ago (2015-08-03 20:55:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263763008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263763008/1
5 years, 4 months ago (2015-08-03 20:57:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-03 22:44:20 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 22:44:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41f22a78a5d385ece47256f1f5605b2029d8621a
Cr-Commit-Position: refs/heads/master@{#341632}

Powered by Google App Engine
This is Rietveld 408576698