Issue 1263763008: Have ClientSocketPoolBase defriend base::RefCounted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1263763008: Have ClientSocketPoolBase defriend base::RefCounted. (Closed)

Created:
5 years, 4 months ago by mmenke

Modified:
5 years, 4 months ago

Reviewers:
eroman

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Have ClientSocketPoolBase defriend base::RefCounted. ClientSocketPoolBase was once refcounted, but they grew apart long ago. BUG=NONE Committed: https://crrev.com/41f22a78a5d385ece47256f1f5605b2029d8621a Cr-Commit-Position: refs/heads/master@{#341632}

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	net/socket/client_socket_pool_base.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

mmenke

Perhaps not really worth the effort, but noticed this when I was looking for classes ...

5 years, 4 months ago (2015-08-03 20:48:24 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263763008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263763008/1

5 years, 4 months ago (2015-08-03 20:57:42 UTC) #5

commit-bot: I haz the power

5 years, 4 months ago (2015-08-03 22:44:49 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/41f22a78a5d385ece47256f1f5605b2029d8621a
Cr-Commit-Position: refs/heads/master@{#341632}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages