Upon load failure, remove sync script from execution queue.

Upon load failure, remove sync script from execution queue.

If a script element is to be loaded synchronously and executed in order,
it's queued for execution before loading. Should that load fail, the
immediate execution of the script,

  https://html.spec.whatwg.org/#execute-the-script-block

should only result in an error event being dispatched.

Implementation-wise, along with signalling error, the failed script must also
be removed from the internal in-order execution queue. We're done with
(not) executing the script and failure to remove it will cause subsequent
processing of the script execution queue to see the script as having failed
to load and re-dispatch an error event.

R=haraken
BUG=503077
Committed: https://crrev.com/2cab4e1498bbaa7934125a6210f4c09003a63ba0
git-svn-id: svn://svn.chromium.org/blink/trunk@199656 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[sof, 2015-07-29 09:08:45]

sigbjornf@opera.com changed reviewers:
+ haraken@chromium.org, tkent@chromium.org

[sof, 2015-07-29 09:08:46]

please take a look.

notifyScriptLoadError() was added in http://crrev.com/82553003 , looks like it
needs to do a bit more work upon in-order failure.

[haraken, 2015-07-29 11:09:12]

LGTM

[sof, 2015-07-29 11:37:39]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-07-29 11:37:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1263743002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1263743002/40001

[commit-bot: I haz the power, 2015-07-29 11:40:21]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199656

[sof, 2015-07-31 05:31:16]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1271443002/ by sigbjornf@opera.com.

The reason for reverting is: Speculatively reverting to see if it addresses the
recent crashes being reported via http://crbug.com/515419.

[sof, 2015-08-05 12:25:26]

please take another/second look?

The first version of this CL that landed was not well-formed, unfortunately -
the assumption made about the state of the in-order script queue was simply
wrong.

Now addressed, so I think this CL is ready for consideration again.

[haraken, 2015-08-05 12:34:01]

LGTM

[sof, 2015-08-05 13:17:50]

Thanks; relanding.

[sof, 2015-08-05 13:18:03]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-08-05 13:18:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1263743002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1263743002/60001

[commit-bot: I haz the power, 2015-08-05 13:20:53]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200045

[hiroshige, 2015-08-06 10:30:15]

The added layout test http/tests/misc/script-sync-slow-scripts-onerror.html is
quite flaky.
Dashboard:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=htt...

[sof, 2015-08-06 12:47:40]

hiroshige@: many thanks for the heads-up on flakiness; will followup next.

[sof, 2015-08-07 19:28:08]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1277273002/ by sigbjornf@opera.com.

The reason for reverting is: Crashes due to a release assert added here are
being reported in https://code.google.com/p/chromium/issues/detail?id=517970 .
Better revert this until that can be looked into more closely..

[commit-bot: I haz the power, 2015-09-23 11:53:26]

Patchset 4 (id:??) landed as
https://crrev.com/2cab4e1498bbaa7934125a6210f4c09003a63ba0