Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1263723002: MIPS: Tweak CEntryStub to free up callee-saved regs s0-s2.

Created:
5 years, 4 months ago by paul.l...
Modified:
5 years, 4 months ago
Reviewers:
balazs.kilvady, ilija.pavlovic, Ilija.Pavlovic1, akos.palfi.imgtec
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Tweak CEntryStub to free up callee-saved regs s0-s2. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -18 lines) Patch
M src/mips/code-stubs-mips.cc View 3 chunks +13 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
paul.l...
PTAL, this is first step in getting some callee-saved regs into our register allocator list, ...
5 years, 4 months ago (2015-07-29 04:49:31 UTC) #2
balazs.kilvady
LGTM.
5 years, 4 months ago (2015-07-29 10:35:44 UTC) #3
Ilija.Pavlovic1
LGTM.
5 years, 4 months ago (2015-07-30 06:26:00 UTC) #5
paul.l...
5 years, 4 months ago (2015-07-30 06:47:11 UTC) #6
This was not needed for interpreter, as callee-saved regs turned out to be
unnecessary there, so the urgency is removed. However, this does remove a couple
instructions, and is probably a worthwhile cleanup. I will revisit this in next
couple days, and add mips64, if I decide to land this.

Powered by Google App Engine
This is Rietveld 408576698