Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 1263703004: Revert of Implement Aura side of unified touch text selection for contents (Closed)

Created:
5 years, 4 months ago by Avi (use Gerrit)
Modified:
5 years, 4 months ago
Reviewers:
avi; congratbot, jdduke (slow), sadrul, mohsen, mfomitchev
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, jdduke+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement Aura side of unified touch text selection for contents (patchset #61 id:1540001 of https://codereview.chromium.org/698253004/) Reason for revert: SitePerProcessBrowserTest.CreateChildFrameAfterKillingProcess SitePerProcessBrowserTest.NavigateRemoteFrameToKilledProcess SitePerProcessBrowserTest.NavigateRemoteFrameToKilledProcessWithSubtree SitePerProcessBrowserTest.NavigatingToKilledProcessRestoresAllProxies started failing on the WinXP, Vista, and Win8 bots: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/39136 http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/58210 http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/32038 Reverting as this is my best guess at being the cause. Original issue's description: > Implement Aura side of unified touch text selection for contents > > This is the first part of unified touch text selection for Aura which > implements it using the new ui::TouchSelectionController for contents. > > Selection updates are now coming from swap-compositor-frame IPC message > instead of selection-bounds-changed IPC message. > > This CL also replaces TouchEditableImplAura (owned by > WebContentsViewAura) with ui::TouchSelectionController (owned by > RenderWidgetHostViewAura) for which a client implementation is provided > in TouchSelectionControllerClientAura. > > Note that at the moment we are unable to remove selection-bounds-changed > IPC message completely as it is also used by IME and the new path is not > yet working properly inside <webview> (which is being worked on). > > Next part would be using ui::TouchSelectionController to implement > unified touch text selection for Views textfields. > > COLLABORATOR=mfomitchev > BUG=399721 > > Committed: https://crrev.com/2a5e3624e4d0b78bfe5f5a3d40f5a98730291056 > Cr-Commit-Position: refs/heads/master@{#341134} TBR=mfomitchev@chromium.org,jdduke@chromium.org,sadrul@chromium.org,avi; congratbot@google.com,mohsen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=399721 Committed: https://crrev.com/dbe96982f5fcab886651d5a12047305441bbb5b3 Cr-Commit-Position: refs/heads/master@{#341195}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1323 lines, -1170 lines) Patch
M content/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
D content/browser/renderer_host/input/touch_selection_controller_client_aura.h View 1 chunk +0 lines, -80 lines 0 comments Download
D content/browser/renderer_host/input/touch_selection_controller_client_aura.cc View 1 chunk +0 lines, -353 lines 0 comments Download
D content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc View 1 chunk +0 lines, -441 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 7 chunks +45 lines, -31 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 24 chunks +39 lines, -90 lines 0 comments Download
A content/browser/web_contents/touch_editable_impl_aura.h View 1 chunk +116 lines, -0 lines 0 comments Download
A content/browser/web_contents/touch_editable_impl_aura.cc View 1 chunk +385 lines, -0 lines 0 comments Download
A content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 1 chunk +638 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 5 chunks +7 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 12 chunks +35 lines, -31 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/content_browser.gypi View 3 chunks +4 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 4 chunks +6 lines, -10 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +1 line, -11 lines 0 comments Download
M content/test/BUILD.gn View 2 chunks +8 lines, -10 lines 0 comments Download
M content/test/data/touch_selection.html View 2 chunks +21 lines, -15 lines 0 comments Download
M ui/touch_selection/BUILD.gn View 2 chunks +0 lines, -14 lines 0 comments Download
D ui/touch_selection/touch_selection_controller_test_api.h View 1 chunk +0 lines, -33 lines 0 comments Download
D ui/touch_selection/touch_selection_controller_test_api.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M ui/touch_selection/touch_selection_controller_unittest.cc View 2 chunks +15 lines, -1 line 0 comments Download
M ui/touch_selection/ui_touch_selection.gyp View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
Created Revert of Implement Aura side of unified touch text selection for contents
5 years, 4 months ago (2015-07-30 21:25:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263703004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263703004/1
5 years, 4 months ago (2015-07-30 21:26:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-30 21:28:32 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 21:29:17 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dbe96982f5fcab886651d5a12047305441bbb5b3
Cr-Commit-Position: refs/heads/master@{#341195}

Powered by Google App Engine
This is Rietveld 408576698