DescriptionRevert of Implement Aura side of unified touch text selection for contents (patchset #61 id:1540001 of https://codereview.chromium.org/698253004/)
Reason for revert:
SitePerProcessBrowserTest.CreateChildFrameAfterKillingProcess
SitePerProcessBrowserTest.NavigateRemoteFrameToKilledProcess
SitePerProcessBrowserTest.NavigateRemoteFrameToKilledProcessWithSubtree
SitePerProcessBrowserTest.NavigatingToKilledProcessRestoresAllProxies
started failing on the WinXP, Vista, and Win8 bots:
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/39136
http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/58210
http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/32038
Reverting as this is my best guess at being the cause.
Original issue's description:
> Implement Aura side of unified touch text selection for contents
>
> This is the first part of unified touch text selection for Aura which
> implements it using the new ui::TouchSelectionController for contents.
>
> Selection updates are now coming from swap-compositor-frame IPC message
> instead of selection-bounds-changed IPC message.
>
> This CL also replaces TouchEditableImplAura (owned by
> WebContentsViewAura) with ui::TouchSelectionController (owned by
> RenderWidgetHostViewAura) for which a client implementation is provided
> in TouchSelectionControllerClientAura.
>
> Note that at the moment we are unable to remove selection-bounds-changed
> IPC message completely as it is also used by IME and the new path is not
> yet working properly inside <webview> (which is being worked on).
>
> Next part would be using ui::TouchSelectionController to implement
> unified touch text selection for Views textfields.
>
> COLLABORATOR=mfomitchev
> BUG=399721
>
> Committed: https://crrev.com/2a5e3624e4d0b78bfe5f5a3d40f5a98730291056
> Cr-Commit-Position: refs/heads/master@{#341134}
TBR=mfomitchev@chromium.org,jdduke@chromium.org,sadrul@chromium.org,avi; congratbot@google.com,mohsen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=399721
Committed: https://crrev.com/dbe96982f5fcab886651d5a12047305441bbb5b3
Cr-Commit-Position: refs/heads/master@{#341195}
Patch Set 1 #
Created: 5 years, 4 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|