Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1495)

Unified Diff: pkg/scheduled_test/lib/scheduled_process.dart

Issue 12637020: Display metadata about out-of-band callbacks in scheduled test errors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: mege Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/scheduled_test/lib/scheduled_test.dart » ('j') | pkg/scheduled_test/lib/src/schedule.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/scheduled_test/lib/scheduled_process.dart
diff --git a/pkg/scheduled_test/lib/scheduled_process.dart b/pkg/scheduled_test/lib/scheduled_process.dart
index 35cb4d855bdab3653c2e75082e0b7d7913bf62dd..799903f75d4a211abca197ff34d8a18d772102a5 100644
--- a/pkg/scheduled_test/lib/scheduled_process.dart
+++ b/pkg/scheduled_test/lib/scheduled_process.dart
@@ -172,7 +172,8 @@ class ScheduledProcess {
throw "Process '${this.description}' ended earlier than scheduled "
"with exit code $exitCode.";
}
- }));
+ }), "waiting to reach shouldExit() or kill() for process "
+ "'${this.description}'");
Bob Nystrom 2013/03/12 20:08:51 Is "this." still needed here (and above)?
nweiz 2013/03/12 20:56:51 Nope. Done.
});
}
@@ -202,7 +203,8 @@ class ScheduledProcess {
_process.value.kill();
// Ensure that the onException queue waits for the process to actually
// exit after being killed.
- wrapFuture(_process.value.exitCode);
+ wrapFuture(_process.value.exitCode, "waiting for process "
+ "'${this.description}' to die");
Bob Nystrom 2013/03/12 20:08:51 Ditto.
nweiz 2013/03/12 20:56:51 Done.
}
return Future.wait([
« no previous file with comments | « no previous file | pkg/scheduled_test/lib/scheduled_test.dart » ('j') | pkg/scheduled_test/lib/src/schedule.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698