Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: content/browser/web_contents/navigation_controller_impl.h

Issue 12637002: Set IsInitialNavigation to false after commit, not document load. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/web_contents/navigation_controller_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/navigation_controller_impl.h
diff --git a/content/browser/web_contents/navigation_controller_impl.h b/content/browser/web_contents/navigation_controller_impl.h
index ac1b2a9425b0821a7b159b8b6c6012775f11b584..5027990f0f7b51a193b79a9341575fa54e75b239 100644
--- a/content/browser/web_contents/navigation_controller_impl.h
+++ b/content/browser/web_contents/navigation_controller_impl.h
@@ -79,7 +79,7 @@ class CONTENT_EXPORT NavigationControllerImpl
virtual bool NeedsReload() const OVERRIDE;
virtual void CancelPendingReload() OVERRIDE;
virtual void ContinuePendingReload() OVERRIDE;
- virtual bool IsInitialNavigation() OVERRIDE;
+ virtual bool IsInitialNavigation() const OVERRIDE;
virtual void Reload(bool check_for_repost) OVERRIDE;
virtual void ReloadIgnoringCache(bool check_for_repost) OVERRIDE;
virtual void ReloadOriginalRequestURL(bool check_for_repost) OVERRIDE;
@@ -118,9 +118,6 @@ class CONTENT_EXPORT NavigationControllerImpl
return web_contents_;
}
- // Called when a document has been loaded in a frame.
- void DocumentLoadedInFrame();
-
// For use by WebContentsImpl ------------------------------------------------
// Handles updating the navigation state after the renderer has navigated.
@@ -380,7 +377,7 @@ class CONTENT_EXPORT NavigationControllerImpl
bool needs_reload_;
// Whether this is the initial navigation.
- // Becomes false when initial navigation is loaded.
+ // Becomes false when initial navigation commits.
bool is_initial_navigation_;
// Used to find the appropriate SessionStorageNamespace for the storage
« no previous file with comments | « no previous file | content/browser/web_contents/navigation_controller_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698