Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1263643003: Changing command line flag from disable appcontainer to enable appcontainer. As there are some repo… (Closed)

Created:
5 years, 4 months ago by Shrikant Kelkar
Modified:
5 years, 4 months ago
Reviewers:
jschuh, nasko, Will Harris
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2403
Target Ref:
refs/pending/branch-heads/2403
Project:
chromium
Visibility:
Public.

Description

Changing command line flag from disable appcontainer to enable appcontainer. As there are some reports on stable channel which suggest that CreateProcess is randomly failing when used with lowbox token, changing disable appcontainer flag to enable if required. BUG=467920 R=wfh@chromium.org, jschuh@chromium.org Review URL: https://codereview.chromium.org/1258173002 Cr-Commit-Position: refs/heads/master@{#340815} (cherry picked from commit 354d94497b96ffa913a7c5d562d2d88d658b9401) Conflicts: content/common/sandbox_win.cc Committed: https://chromium.googlesource.com/chromium/src/+/cbce740e72c523a585310946316803f57dca7174

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Shrikant Kelkar
5 years, 4 months ago (2015-07-30 21:15:41 UTC) #1
Will Harris
lgtm for merge into M44
5 years, 4 months ago (2015-07-30 21:18:57 UTC) #2
Shrikant Kelkar
5 years, 4 months ago (2015-07-30 21:28:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cbce740e72c523a585310946316803f57dca7174.

Powered by Google App Engine
This is Rietveld 408576698