Moves CandidateWindow model to ui/base/ime.

Moves CandidateWindow model to ui/base/ime.

BUG=325813
R=komatsu@chromium.org
TEST=build passes

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243777

[Hiro Komatsu, 2014-01-08 03:51:15]

On 2014/01/07 20:07:55, Jun Mukai wrote:

How about moving the files to ui/base/ime/chromeos ?

[Hiro Komatsu, 2014-01-08 03:51:25]

lgtm

https://codereview.chromium.org/126363002/diff/10001/ui/base/ime/candidate_wi...
File ui/base/ime/candidate_window.h (right):

https://codereview.chromium.org/126363002/diff/10001/ui/base/ime/candidate_wi...
ui/base/ime/candidate_window.h:14: namespace ui {
What do you think to add "ime" namespace?  (i.e. ui::ime::CandidateWindow).

You do not need it in this patch anyway.

[Jun Mukai, 2014-01-08 05:03:12]

On 2014/01/08 03:51:15, Hiro Komatsu wrote:
> On 2014/01/07 20:07:55, Jun Mukai wrote:
> 
> How about moving the files to ui/base/ime/chromeos ?

I don't want to add 'chromeos' thing. If so, depending files (including views
UI) entail chromeos, which makes harder to put ash or ui/views.
Also I think the concept of 'candidate window' isn't chromeos specific.

[Jun Mukai, 2014-01-08 05:04:32]

https://codereview.chromium.org/126363002/diff/10001/ui/base/ime/candidate_wi...
File ui/base/ime/candidate_window.h (right):

https://codereview.chromium.org/126363002/diff/10001/ui/base/ime/candidate_wi...
ui/base/ime/candidate_window.h:14: namespace ui {
On 2014/01/08 03:51:26, Hiro Komatsu wrote:
> What do you think to add "ime" namespace?  (i.e. ui::ime::CandidateWindow).
> 
> You do not need it in this patch anyway.

I am not so sure about the namespace policy. There's no such namespace ui::ime
right now, all other files of this directory just use ui namespace. So I think
it's better to keep this.

[Hiro Komatsu, 2014-01-08 06:18:52]

On 2014/01/08 05:03:12, Jun Mukai wrote:
> On 2014/01/08 03:51:15, Hiro Komatsu wrote:
> > On 2014/01/07 20:07:55, Jun Mukai wrote:
> > 
> > How about moving the files to ui/base/ime/chromeos ?
> 
> I don't want to add 'chromeos' thing. If so, depending files (including views
> UI) entail chromeos, which makes harder to put ash or ui/views.
> Also I think the concept of 'candidate window' isn't chromeos specific.

As you mentioned, candidate_window.h / cc are platform independent.  But, 
Chrome OS is the only platform which uses those files.

That said, I do not have strong opinion about it.  So up to you.

[Hiro Komatsu, 2014-01-08 06:20:26]

On 2014/01/08 05:04:32, Jun Mukai wrote:
>
https://codereview.chromium.org/126363002/diff/10001/ui/base/ime/candidate_wi...
> File ui/base/ime/candidate_window.h (right):
> 
>
https://codereview.chromium.org/126363002/diff/10001/ui/base/ime/candidate_wi...
> ui/base/ime/candidate_window.h:14: namespace ui {
> On 2014/01/08 03:51:26, Hiro Komatsu wrote:
> > What do you think to add "ime" namespace?  (i.e. ui::ime::CandidateWindow).
> > 
> > You do not need it in this patch anyway.
> 
> I am not so sure about the namespace policy. There's no such namespace ui::ime
> right now, all other files of this directory just use ui namespace. So I think
> it's better to keep this.

Right.  I think it is a good idea to add ui::ime namespace to all modules.
Anyway, it is not the scope of this patch.

[commit-bot: I haz the power, 2014-01-08 21:58:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/126363002/10001

[commit-bot: I haz the power, 2014-01-09 01:12:15]

Retried try job too often on win_x64_rel for step(s) base_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...

[commit-bot: I haz the power, 2014-01-09 01:28:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/126363002/400001

[commit-bot: I haz the power, 2014-01-09 04:51:49]

Change committed as 243777