chrome/android/java/res/layout/custom_tabs_toolbar.xml - Issue 1263573011: Let client specify content description for custom action button

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/custom_tabs_toolbar.xml

Issue 1263573011: Let client specify content description for custom action button (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/custom_tabs_toolbar.xml

diff --git a/chrome/android/java/res/layout/custom_tabs_toolbar.xml b/chrome/android/java/res/layout/custom_tabs_toolbar.xml

index 1981c3c4c9af5e83c7f16c9c458c1b89bbce456a..19ac4b7ca0cf4767232b1a3ef38ca17d9279bb83 100644

--- a/chrome/android/java/res/layout/custom_tabs_toolbar.xml

+++ b/chrome/android/java/res/layout/custom_tabs_toolbar.xml

@@ -68,7 +68,7 @@

android:layout_marginEnd="42dp"

android:layout_gravity="center_vertical|end"

android:visibility="gone"

- android:contentDescription="@string/accessibility_toolbar_btn_custom" />

Yusuf 2015/08/05 18:43:04 We might still want to keep this to avoid lint get

+ android:contentDescription="@null" />

<org.chromium.chrome.browser.widget.TintedImageButton

android:id="@+id/menu_button"

style="@style/ToolbarButton"