Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1851)

Issue 1263563002: Correct handling of temporaries as parameters. (Closed)

Created:
5 years, 4 months ago by rossberg
Modified:
5 years, 4 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Correct handling of temporaries as parameters. They need to be properly recorded in the scope's temps set, otherwise allocation doesn't know about them and can break. (Not observable right now, but necessary for follow-up changes to parameter destructuring.) Also, print temporary variables in a useful manner. R=adamk@chromium.org BUG= Committed: https://crrev.com/222b70d10ff00e67183f1779022e404f1bf9d746 Cr-Commit-Position: refs/heads/master@{#29998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M src/parser.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/scopes.cc View 4 chunks +15 lines, -9 lines 0 comments Download
M src/variables.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
rossberg
5 years, 4 months ago (2015-07-28 15:28:08 UTC) #1
adamk
lgtm
5 years, 4 months ago (2015-07-30 17:08:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263563002/1
5 years, 4 months ago (2015-08-04 12:38:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-04 13:03:42 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 13:04:04 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/222b70d10ff00e67183f1779022e404f1bf9d746
Cr-Commit-Position: refs/heads/master@{#29998}

Powered by Google App Engine
This is Rietveld 408576698