Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 1263543004: Fix prototype registration upon SlowToFast migration (Closed)

Created:
5 years, 4 months ago by Jakob Kummerow
Modified:
5 years, 4 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix prototype registration upon SlowToFast migration When a prototype object migrates from a slow to a fast map, where the slow map was registered as a user of its own prototype, then the registration must be transferred to the new map (just like MigrateToMap does for all other cases). BUG=chromium:513602 LOG=y NOTREECHECKS=true Committed: https://crrev.com/c906efd5d18dba6e391fc536a594a50885c13f49 Cr-Commit-Position: refs/heads/master@{#29898}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -8 lines) Patch
M src/objects.cc View 2 chunks +20 lines, -8 lines 1 comment Download
A test/mjsunit/regress/regress-crbug-513602.js View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
PTAL. https://codereview.chromium.org/1263543004/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1263543004/diff/1/src/objects.cc#newcode4659 src/objects.cc:4659: if (maybe_old_prototype->IsJSObject()) { This if-block is new; the ...
5 years, 4 months ago (2015-07-28 15:14:19 UTC) #2
ulan
lgtm
5 years, 4 months ago (2015-07-28 15:18:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263543004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263543004/1
5 years, 4 months ago (2015-07-28 15:19:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-28 15:41:26 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 15:41:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c906efd5d18dba6e391fc536a594a50885c13f49
Cr-Commit-Position: refs/heads/master@{#29898}

Powered by Google App Engine
This is Rietveld 408576698