Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: printing/BUILD.gn

Issue 1263513004: Get content_unittests to link on the mac GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@enable_mac_net_unittests
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/BUILD.gn
diff --git a/printing/BUILD.gn b/printing/BUILD.gn
index d035801419310612bfe216ce94d81632b5cf9998..80d70e49e8cb48612615b213eac5e3e16be0e15e 100644
--- a/printing/BUILD.gn
+++ b/printing/BUILD.gn
@@ -226,7 +226,8 @@ if (use_cups) {
defines = [ "USE_CUPS" ]
if (is_mac) {
- ldflags = [ "$mac_sdk_path/usr/lib/libcups.dylib" ]
+ libs = [ "cups" ]
+ lib_dirs = [ "$mac_sdk_path/usr/lib" ]
Dirk Pranke 2015/07/31 19:58:34 I think using ldflags was almost certainly wrong h
brettw 2015/07/31 21:35:04 Nope, that's what you're supposed to do.
} else {
libs = exec_script("cups_config_helper.py", [ "--libs-for-gn" ], "value")
}
« no previous file with comments | « content/test/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698