Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 12635010: Start building message_center on Mac. (Closed)

Created:
7 years, 9 months ago by Robert Sesek
Modified:
7 years, 9 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

Start building message_center on Mac. BUG=179904, 179916 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188039

Patch Set 1 #

Patch Set 2 : IsRichNotificationEnabled uses a flag on mac #

Patch Set 3 : '' #

Patch Set 4 : Disable tests #

Patch Set 5 : Rebase #

Patch Set 6 : MessageCenterNotificationsTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -19 lines) Patch
M build/common.gypi View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_crash_recovery_browsertest.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/notifications/message_center_notifications_browsertest.cc View 1 2 3 4 5 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_browsertest.cc View 1 2 3 13 chunks +23 lines, -14 lines 0 comments Download
M chrome/browser/notifications/notification_ui_manager_mac.mm View 2 chunks +15 lines, -0 lines 0 comments Download
M ui/message_center/message_center.gyp View 2 chunks +11 lines, -1 line 0 comments Download
M ui/message_center/message_center_tray.cc View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M ui/message_center/message_center_tray_delegate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/message_center/message_center_util.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Robert Sesek
Trying to get the code building and tests skipped/disabled so that I can check in ...
7 years, 9 months ago (2013-03-13 21:04:47 UTC) #1
miket_OOO
lgtm
7 years, 9 months ago (2013-03-13 22:37:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/12635010/19001
7 years, 9 months ago (2013-03-13 23:10:23 UTC) #3
Robert Sesek
7 years, 9 months ago (2013-03-14 12:00:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #6 manually as r188039 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698