Issue 12635009: Add --gpucache size to bench.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12635009: Add --gpucache size to bench. (Closed)

Created:
7 years, 9 months ago by bsalomon

Modified:
7 years, 9 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add --gpucache size to bench. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=8075

Patch Set 3 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -5 lines)			Patch
	M	bench/benchmain.cpp	View	1 2	5 chunks	+48 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + nits (that may be retroactive to 'gm' too https://codereview.chromium.org/12635009/diff/3001/bench/benchmain.cpp File bench/benchmain.cpp (right): https://codereview.chromium.org/12635009/diff/3001/bench/benchmain.cpp#newcode285 ...

7 years, 9 months ago (2013-03-08 20:55:20 UTC) #2

bsalomon

https://codereview.chromium.org/12635009/diff/3001/bench/benchmain.cpp File bench/benchmain.cpp (right): https://codereview.chromium.org/12635009/diff/3001/bench/benchmain.cpp#newcode285 bench/benchmain.cpp:285: #if SK_SUPPORT_GPU On 2013/03/08 20:55:20, robertphillips wrote: > We ...

7 years, 9 months ago (2013-03-08 21:04:15 UTC) #3

bsalomon

7 years, 9 months ago (2013-03-11 20:22:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r8075 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12635009: Add --gpucache size to bench. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages