Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1263473008: SIMD.js Fix x87 build. (Closed)

Created:
5 years, 4 months ago by bbudge
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

SIMD.js Fix x87 build. Rename method EmitIsSpecObject -> EmitIsSimdObject. LOG=N BUG=v8:4124 Committed: https://crrev.com/565fe3f01770591be015e0ca02099002bcc23b99 Cr-Commit-Position: refs/heads/master@{#29980}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
bbudge
5 years, 4 months ago (2015-08-03 14:44:32 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 4 months ago (2015-08-03 15:15:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263473008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263473008/1
5 years, 4 months ago (2015-08-03 15:16:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4646)
5 years, 4 months ago (2015-08-03 15:19:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263473008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263473008/1
5 years, 4 months ago (2015-08-03 15:30:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-03 15:32:45 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 15:33:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/565fe3f01770591be015e0ca02099002bcc23b99
Cr-Commit-Position: refs/heads/master@{#29980}

Powered by Google App Engine
This is Rietveld 408576698