Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1263473002: X87: [stubs] Properly handle read-only properties in StoreGlobalViaContextStub. (Closed)

Created:
5 years, 4 months ago by chunyang.dai
Modified:
5 years, 4 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [stubs] Properly handle read-only properties in StoreGlobalViaContextStub. port cac64b9f634743f7f5311d4dca8d50157b10fab5 (r29881) original commit message: We don't need the hole check and slow runtime mode for read-only properties this way. BUG= Committed: https://crrev.com/02f097487cb69c1b51712e8b3c6e767b0f892fdf Cr-Commit-Position: refs/heads/master@{#29891}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M src/x87/code-stubs-x87.cc View 3 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 4 months ago (2015-07-28 07:49:04 UTC) #2
Weiliang
lgtm
5 years, 4 months ago (2015-07-28 08:10:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263473002/1
5 years, 4 months ago (2015-07-28 08:10:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-28 08:34:39 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 08:34:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02f097487cb69c1b51712e8b3c6e767b0f892fdf
Cr-Commit-Position: refs/heads/master@{#29891}

Powered by Google App Engine
This is Rietveld 408576698