Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 1263443003: [NaCl SDK] Fix bionic build of nacl_io (Closed)

Created:
5 years, 4 months ago by Sam Clegg
Modified:
5 years, 4 months ago
Reviewers:
binji
CC:
binji+watch_chromium.org, chromium-reviews, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Fix bionic build of nacl_io Committed: https://crrev.com/f9f5db109d6d378bcacaa7912280a3b920c3f1e9 Cr-Commit-Position: refs/heads/master@{#341210}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M native_client_sdk/src/libraries/nacl_io/kernel_wrap_bionic.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Sam Clegg
5 years, 4 months ago (2015-07-30 18:01:50 UTC) #2
binji
lgtm
5 years, 4 months ago (2015-07-30 21:30:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263443003/1
5 years, 4 months ago (2015-07-30 21:34:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-30 22:29:12 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 22:29:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9f5db109d6d378bcacaa7912280a3b920c3f1e9
Cr-Commit-Position: refs/heads/master@{#341210}

Powered by Google App Engine
This is Rietveld 408576698