chrome/browser/first_run/try_chrome_dialog_view.cc - Issue 12634025: Inconsistent use of [x] close panel icon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/first_run/try_chrome_dialog_view.cc

Issue 12634025: Inconsistent use of [x] close panel icon (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_173251

Patch Set: Fixed compile on linux, mac and win Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/first_run/try_chrome_dialog_view.cc

diff --git a/chrome/browser/first_run/try_chrome_dialog_view.cc b/chrome/browser/first_run/try_chrome_dialog_view.cc

index 11042a71cb7439093d64d428e432f8e7595937d0..01ade214cf7a7a07dd1ff87713d9de71b1e032dc 100644

--- a/chrome/browser/first_run/try_chrome_dialog_view.cc

+++ b/chrome/browser/first_run/try_chrome_dialog_view.cc

@@ -192,11 +192,11 @@ TryChromeDialogView::Result TryChromeDialogView::ShowModal(

// The close button is custom.

views::ImageButton* close_button = new views::ImageButton(this);

close_button->SetImage(views::CustomButton::STATE_NORMAL,

- rb.GetNativeImageNamed(IDR_CLOSE_BAR).ToImageSkia());

+ rb.GetNativeImageNamed(IDR_CLOSE_2).ToImageSkia());

close_button->SetImage(views::CustomButton::STATE_HOVERED,

- rb.GetNativeImageNamed(IDR_CLOSE_BAR_H).ToImageSkia());

+ rb.GetNativeImageNamed(IDR_CLOSE_2_H).ToImageSkia());

close_button->SetImage(views::CustomButton::STATE_PRESSED,

- rb.GetNativeImageNamed(IDR_CLOSE_BAR_P).ToImageSkia());

+ rb.GetNativeImageNamed(IDR_CLOSE_2_P).ToImageSkia());

close_button->set_tag(BT_CLOSE_BUTTON);

layout->AddView(close_button);