chrome/app/theme/theme_resources.grd - Issue 12634025: Inconsistent use of [x] close panel icon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/theme/theme_resources.grd

Issue 12634025: Inconsistent use of [x] close panel icon (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_173251

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/app/theme/theme_resources.grd

diff --git a/chrome/app/theme/theme_resources.grd b/chrome/app/theme/theme_resources.grd

index 8454eacc9ecc11ccf55d45ea0f6a286e9eb7fd21..0d33ec09469759edd9653a76ee5df18234b3499c 100644

--- a/chrome/app/theme/theme_resources.grd

+++ b/chrome/app/theme/theme_resources.grd

@@ -752,10 +752,10 @@

</if>

- <structure type="chrome_scaled_image" name="IDR_TAB_CLOSE" file="common/tab_close_normal.png" />

- <structure type="chrome_scaled_image" name="IDR_TAB_CLOSE_H" file="common/tab_close_hover.png" />

- <structure type="chrome_scaled_image" name="IDR_TAB_CLOSE_MASK" file="common/tab_close_mask.png" />

- <structure type="chrome_scaled_image" name="IDR_TAB_CLOSE_P" file="common/tab_close_pressed.png" />

+ <structure type="chrome_scaled_image" name="IDR_CLOSE_1" file="common/button_close_1_normal.png" />

sky 2013/03/22 18:08:30 File name and IDR name should match (same comment

varkha 2013/03/22 18:12:27 So in this case file="common/close_1_normal.png" o

sky 2013/03/22 19:32:29 close_1.png

+ <structure type="chrome_scaled_image" name="IDR_CLOSE_1_H" file="common/button_close_1_hover.png" />

+ <structure type="chrome_scaled_image" name="IDR_CLOSE_1_MASK" file="common/button_close_1_mask.png" />

+ <structure type="chrome_scaled_image" name="IDR_CLOSE_1_P" file="common/button_close_1_pressed.png" />