Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 12634024: More SkDrawCommand cleanup (Closed)

Created:
7 years, 9 months ago by robertphillips
Modified:
7 years, 9 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

These changes prepare the debug canvas for having its SkPicture deleted out from under it (as the debugger's SaveAs feature does).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -88 lines) Patch
M debugger/SkDrawCommand.h View 7 chunks +49 lines, -25 lines 0 comments Download
M debugger/SkDrawCommand.cpp View 8 chunks +97 lines, -63 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robertphillips
7 years, 9 months ago (2013-03-22 14:41:45 UTC) #1
djsollen
lgtm
7 years, 9 months ago (2013-03-22 15:16:04 UTC) #2
robertphillips
7 years, 9 months ago (2013-03-22 16:35:48 UTC) #3
Message was sent while issue was closed.
committed as r8340

Powered by Google App Engine
This is Rietveld 408576698