NetworkChangeNotifierChromeos: Handle IPConfig property changes on the default network

chromeos/dbus/shill_service_client.h

Index: chromeos/dbus/shill_service_client.h
diff --git a/chromeos/dbus/shill_service_client.h b/chromeos/dbus/shill_service_client.h
index 7f9e9b149419fffbd5ae0dd7c8190edd4d43e43d..d9168dfc51e67590163aa94919df41748cbdcb8d 100644
--- a/chromeos/dbus/shill_service_client.h
+++ b/chromeos/dbus/shill_service_client.h
@@ -48,6 +48,7 @@ class CHROMEOS_EXPORT ShillServiceClient {
                             const std::string& name,
                             const std::string& type,
                             const std::string& state,
+                            const std::string& ipconfig_path,

[stevenjb, 2013/03/27 22:18:52]

Do we really want to add this to AddService()? It doesn't seem like an essential
property. Why not just use SetServiceProperty() when we want to set it?

[gauravsh, 2013/03/27 23:16:04]

This is needed because there are 2 distinct scenarios that I'd like to test. We
have 2 separate code paths for IPConfig requests - one when we add the service
the first time with IPConfig set, and the second when a service's IPConfig
property changes (or gets added).

Open to alternative suggestions. How about a separate AddService version that
takes the IPConfig path?

[stevenjb, 2013/03/27 23:55:10]

Yeah, I'd prefer a separate AddServiceWithIpconfig() then, thanks.

[pneubeck (no reviews), 2013/03/28 10:37:54]

If you want to have initial properties set, then why not add a more scalable
properties argument:
AddServiceWithProperties(...., const DictionaryValue& initial_properties)
(instead of const&, scoped_ptr might be an alternative)

This would also help Manager::ConfigureService and maybe other places.

                             bool add_to_watch_list) = 0;
     virtual void RemoveService(const std::string& service_path) = 0;
     virtual void SetServiceProperty(const std::string& service_path,