NetworkChangeNotifierChromeos: Handle IPConfig property changes on the default network

chromeos/network/network_state.h

Index: chromeos/network/network_state.h
diff --git a/chromeos/network/network_state.h b/chromeos/network/network_state.h
index 6e7890b93bad5dff04b1d6549cdce8de24839a3f..8bba4e470debe392fdccd7f8b8539eca779266d2 100644
--- a/chromeos/network/network_state.h
+++ b/chromeos/network/network_state.h
@@ -36,6 +36,7 @@ class CHROMEOS_EXPORT NetworkState : public ManagedState {
   // Accessors
   const std::string& security() const { return security_; }
   const std::string& ip_address() const { return ip_address_; }
+  const std::string& dns_servers() const { return dns_servers_; }
   const std::string& device_path() const { return device_path_; }
   const std::string& guid() const { return guid_; }
   const std::string& connection_state() const { return connection_state_; }
@@ -66,14 +67,21 @@ class CHROMEOS_EXPORT NetworkState : public ManagedState {
   void set_ip_address(const std::string& ip_address) {
     ip_address_ = ip_address;
   }
+  void set_dns_servers(const std::string& dns_servers) {
+    dns_servers_ = dns_servers;
+  }
 
   // Common Network Service properties
   std::string security_;
   std::string device_path_;
   std::string guid_;
-  std::string ip_address_;
   std::string connection_state_;
   std::string error_;
+  // IPConfig properties.
+  // Note: These do not correspond to actual Shill.Service properties
+  // but are derived from the service's corresponding IPConfig object.
+  std::string ip_address_;
+  std::string dns_servers_;

[pneubeck (no reviews), 2013/03/28 10:37:54]

Why does dns_servers have to be a string?
If anybody will ever use the value itself (the notifier doesn't do that), we
just have to parse it again...

better use std::vector<std::string>

[gauravsh, 2013/03/28 18:48:54]

I guess the reverse question is - why does it need to be a vector?

I made this a comma separated string since that's how the current NetworkLibrary
code stores it - see NetworkIPConfig. I assumed, perhaps incorrectly, that there
was a good reason to do so, say since it's only used to display at the network
config/info screen.

gspencer/stevenjb: Can you comment on the reason why NetworkIPConfig stores DNS
servers as a comma separated string?

[stevenjb, 2013/03/28 19:27:13]

I don't know that I would say that there was a *good* reason to use a CSV for
dns_servers (name_servers in NetworkIPConfig), but searching through the code it
looks like we:

* Compare strings, which is a little simpler with a CSV than a vector<string>
* Use at least one const, kGoogleNameServers, which is currently a simple CSV

I don't think we should re-factor that code here, so lets keep it as a string
for now.

   // Wireless properties
   int signal_strength_;
   // Cellular properties