NetworkChangeNotifierChromeos: Handle IPConfig property changes on the default network

chromeos/network/network_state_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/network_state_handler.h"
 
 #include "base/format_macros.h"
 #include "base/stl_util.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
@@ skipping 375 matching lines @@
 void NetworkStateHandler::UpdateNetworkServiceProperty(
     const std::string& service_path,
     const std::string& key,
     const base::Value& value) {
   NetworkState* network = GetModifiableNetworkState(service_path);
   if (!network)
     return;
   std::string prev_connection_state = network->connection_state();
   if (!network->PropertyChanged(key, value))
     return;
-  if (network->connection_state() != prev_connection_state)
+  if (network->connection_state() != prev_connection_state) {
     OnNetworkConnectionStateChanged(network);
+  } else if (network->path() == default_network_path_) {
+    // WiFi signal strength updates are too noisy, so don't
+    // trigger default network updates for those changes.
+    if (key != flimflam::kSignalStrengthProperty)

[stevenjb, 2013/03/27 22:18:52]

nit: add to if clause above

[gauravsh, 2013/03/27 23:16:04]

Done.

+      OnDefaultNetworkChanged();
+  }
 
   NetworkPropertiesUpdated(network);
 
   std::string detail = network->name() + "." + key;
   std::string vstr = ValueAsString(value);
   if (!vstr.empty())
     detail += " = " + vstr;
   network_event_log::AddEntry(kLogModule, "NetworkPropertyUpdated", detail);
 }
 
-void NetworkStateHandler::UpdateNetworkServiceIPAddress(
-    const std::string& service_path,
-    const std::string& ip_address) {
-  NetworkState* network = GetModifiableNetworkState(service_path);
-  if (!network)
-    return;
-  std::string detail = network->name() + ".IPAddress = " + ip_address;
-  network_event_log::AddEntry(kLogModule, "NetworkIPChanged", detail);
-  network->set_ip_address(ip_address);
-  NetworkPropertiesUpdated(network);
-}
-
 void NetworkStateHandler::UpdateDeviceProperty(const std::string& device_path,
                                                const std::string& key,
                                                const base::Value& value) {
   DeviceState* device = GetModifiableDeviceState(device_path);
   if (!device)
     return;
   if (!device->PropertyChanged(key, value))
     return;
 
   FOR_EACH_OBSERVER(NetworkStateHandlerObserver, observers_,
@@ skipping 113 matching lines @@
 
 void NetworkStateHandler::NetworkPropertiesUpdated(
     const NetworkState* network) {
   if (network->path() == connecting_network_ && !network->IsConnectingState())
     connecting_network_.clear();
   FOR_EACH_OBSERVER(NetworkStateHandlerObserver, observers_,
                     NetworkPropertiesUpdated(network));
 }
 
 }  // namespace chromeos