NetworkChangeNotifierChromeos: Handle IPConfig property changes on the default network

chromeos/dbus/shill_ipconfig_client_stub.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/dbus/shill_ipconfig_client_stub.h"
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "base/stl_util.h"
 #include "base/values.h"
@@ skipping 25 matching lines @@
 
 void ShillIPConfigClientStub::Refresh(const dbus::ObjectPath& ipconfig_path,
                                       const VoidDBusMethodCallback& callback) {
 }
 
 void ShillIPConfigClientStub::GetProperties(
     const dbus::ObjectPath& ipconfig_path,
     const DictionaryValueCallback& callback) {
   if (callback.is_null())
     return;
+  const base::DictionaryValue* dict = NULL;
+  if (!stub_ipconfig_.GetDictionaryWithoutPathExpansion(ipconfig_path.value(),
+                                                        &dict))
+    return;
   MessageLoop::current()->PostTask(
-      FROM_HERE, base::Bind(&ShillIPConfigClientStub::PassProperties,
-                            weak_ptr_factory_.GetWeakPtr(),
-                            callback));
+        FROM_HERE, base::Bind(&ShillIPConfigClientStub::PassProperties,
+                              weak_ptr_factory_.GetWeakPtr(),
+                              dict,
+                              callback));
 }
 
 base::DictionaryValue* ShillIPConfigClientStub::CallGetPropertiesAndBlock(
     const dbus::ObjectPath& ipconfig_path) {
   return new base::DictionaryValue;
 }
 
 void ShillIPConfigClientStub::SetProperty(
     const dbus::ObjectPath& ipconfig_path,
     const std::string& name,
     const base::Value& value,
     const VoidDBusMethodCallback& callback) {
   if (callback.is_null())
     return;
+  base::DictionaryValue* dict = NULL;
+  if (!stub_ipconfig_.GetDictionaryWithoutPathExpansion(ipconfig_path.value(),

[pneubeck (no reviews), 2013/03/28 10:37:54]

swap cases.

[gauravsh, 2013/03/28 18:48:54]

Curious, Why?

[stevenjb, 2013/03/28 19:27:13]

Usually the positive test should proceed the negative case, and I agree that
that would be slightly more clear here, but it really should be a nit.

[gauravsh, 2013/03/28 19:54:23]

Done.

+                                                        &dict)) {
+    // Create a new stub ipconfig object, and update its properties.
+    DictionaryValue* dvalue = new DictionaryValue;
+    dvalue->SetWithoutPathExpansion(name, value.DeepCopy());
+    stub_ipconfig_.SetWithoutPathExpansion(ipconfig_path.value(),
+                                           dvalue);
+  } else {
+    // Update existing ip config stub object's properties.
+    dict->SetWithoutPathExpansion(name, value.DeepCopy());
+  }
   MessageLoop::current()->PostTask(
       FROM_HERE, base::Bind(callback, DBUS_METHOD_CALL_SUCCESS));
 }
 
 void ShillIPConfigClientStub::ClearProperty(
     const dbus::ObjectPath& ipconfig_path,
     const std::string& name,
     const VoidDBusMethodCallback& callback) {
   if (callback.is_null())
     return;
   MessageLoop::current()->PostTask(
       FROM_HERE, base::Bind(callback, DBUS_METHOD_CALL_SUCCESS));
 }
 
 void ShillIPConfigClientStub::Remove(const dbus::ObjectPath& ipconfig_path,
                                      const VoidDBusMethodCallback& callback) {
   if (callback.is_null())
     return;
   MessageLoop::current()->PostTask(
       FROM_HERE, base::Bind(callback, DBUS_METHOD_CALL_SUCCESS));
 }
 
 void ShillIPConfigClientStub::PassProperties(
+    const base::DictionaryValue* values,
     const DictionaryValueCallback& callback) const {
-  callback.Run(DBUS_METHOD_CALL_SUCCESS, properties_);
+  callback.Run(DBUS_METHOD_CALL_SUCCESS, *values);
 }
 
 }  // namespace chromeos