Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 12634010: [nacltoons] Add Makefile for building lua bindings. (Closed)

Created:
7 years, 9 months ago by Sam Clegg
Modified:
7 years, 9 months ago
Reviewers:
noelallen1
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

[nacltoons] Add Makefile for building lua bindings. Include basic.lua helper script which performs some modifications on the generated code. BUG=None Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1528

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -28 lines) Patch
M nacltoons/bindings/LuaCocos2dExtensions.h View 1 2 1 chunk +1 line, -6 lines 0 comments Download
M nacltoons/bindings/LuaCocos2dExtensions.cpp View 1 2 1 chunk +16 lines, -4 lines 0 comments Download
A nacltoons/bindings/Makefile View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
M nacltoons/bindings/README View 1 chunk +3 lines, -5 lines 0 comments Download
M nacltoons/bindings/extensions.pkg View 1 chunk +1 line, -1 line 0 comments Download
M nacltoons/bindings/lua_level_layer.h View 1 2 1 chunk +2 lines, -6 lines 0 comments Download
M nacltoons/bindings/lua_level_layer.cpp View 1 2 4 chunks +20 lines, -6 lines 0 comments Download
A nacltoons/bindings/post_process.py View 1 2 1 chunk +43 lines, -0 lines 1 comment Download
A nacltoons/bindings/tolua_preload.lua View 1 2 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Sam Clegg
7 years, 9 months ago (2013-03-08 20:27:47 UTC) #1
noelallen1
https://codereview.chromium.org/12634010/diff/2001/nacltoons/bindings/Makefile File nacltoons/bindings/Makefile (right): https://codereview.chromium.org/12634010/diff/2001/nacltoons/bindings/Makefile#newcode7 nacltoons/bindings/Makefile:7: #HELPER = ../../third_party/cocos2d-x/tools/tolua++/basic.lua What is this? Comment or remove. ...
7 years, 9 months ago (2013-03-08 21:52:01 UTC) #2
Sam Clegg
https://codereview.chromium.org/12634010/diff/2001/nacltoons/bindings/Makefile File nacltoons/bindings/Makefile (right): https://codereview.chromium.org/12634010/diff/2001/nacltoons/bindings/Makefile#newcode7 nacltoons/bindings/Makefile:7: #HELPER = ../../third_party/cocos2d-x/tools/tolua++/basic.lua On 2013/03/08 21:52:01, noelallen1 wrote: > ...
7 years, 9 months ago (2013-03-08 22:22:53 UTC) #3
noelallen1
This is still very unreadable. Sounds like switching the lua to a few lines of ...
7 years, 9 months ago (2013-03-09 01:06:43 UTC) #4
Sam Clegg
Post processing is now done by post_process.py. basic.lua renamed tolua_preload.lua to more accurately reflect what ...
7 years, 9 months ago (2013-03-09 01:25:46 UTC) #5
noelallen1
lgtm https://codereview.chromium.org/12634010/diff/18001/nacltoons/bindings/post_process.py File nacltoons/bindings/post_process.py (right): https://codereview.chromium.org/12634010/diff/18001/nacltoons/bindings/post_process.py#newcode40 nacltoons/bindings/post_process.py:40: return 0
7 years, 9 months ago (2013-03-09 02:05:05 UTC) #6
Sam Clegg
7 years, 9 months ago (2013-03-09 02:07:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r1528 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698