Issue 12634: * Postponed irregexp parser forward scan of capturing parentheses until necessary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12634: * Postponed irregexp parser forward scan of capturing parentheses until necessary. (Closed)

Created:
12 years ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Scanning for captures only happen when a decimal escape gives a number that is too big to be a useful back reference. It won't happen at all in meaningfull ECMAScript compliant regexps.

Patch Set 1 #

Patch Set 2 : Addressed review comments #

Patch Set 3 : Rebase to head of bleeding edge #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -15 lines)			Patch
	M	src/parser.cc	View	1	6 chunks	+19 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

12 years ago (2008-11-25 13:21:03 UTC) #2

LGTM.  I think the declaration of capture_count should get a comment explaining
that it is only valid when is_scanned_for_captures_ is true.

Expand Messages | Collapse Messages