Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1263393002: Gather debugging information for the switch away from page id for titles and state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pageid Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/crash_keys.cc ('k') | content/public/common/page_state.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 287d01681cda15a27dfb693ec2606c1838bdc8cf..f87a381c3e8d751316186f7a9eadf2989c7d78cd 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -7,6 +7,7 @@
#include <utility>
#include "base/command_line.h"
+#include "base/debug/crash_logging.h"
#include "base/lazy_instance.h"
#include "base/location.h"
#include "base/logging.h"
@@ -3882,6 +3883,7 @@ void WebContentsImpl::UpdateState(RenderViewHost* rvh,
NavigationEntryImpl* new_entry = controller_.GetEntryWithUniqueID(
rvhi->nav_entry_id());
+ CHECK(new_entry);
if (SiteIsolationPolicy::UseSubframeNavigationEntries()) {
// TODO(creis): We can't properly update state for cross-process subframes
@@ -3889,7 +3891,23 @@ void WebContentsImpl::UpdateState(RenderViewHost* rvh,
// method.
entry = new_entry;
} else {
- DCHECK_EQ(entry, new_entry);
+ base::debug::SetCrashKeyValue("pageid", base::IntToString(page_id));
+ base::debug::SetCrashKeyValue("navuniqueid",
+ base::IntToString(rvhi->nav_entry_id()));
+ base::debug::SetCrashKeyValue(
+ "oldindex", base::IntToString(controller_.GetIndexOfEntry(entry)));
+ base::debug::SetCrashKeyValue(
+ "newindex", base::IntToString(controller_.GetIndexOfEntry(new_entry)));
+ base::debug::SetCrashKeyValue(
+ "lastcommittedindex",
+ base::IntToString(controller_.GetLastCommittedEntryIndex()));
+ base::debug::SetCrashKeyValue("oldurl", entry->GetURL().spec());
+ base::debug::SetCrashKeyValue("newurl", new_entry->GetURL().spec());
+ base::debug::SetCrashKeyValue(
+ "updatedvalue", page_state.GetTopLevelUrlStringTemporaryForBug369661());
+ base::debug::SetCrashKeyValue("oldvalue", entry->GetURL().spec());
+ base::debug::SetCrashKeyValue("newvalue", new_entry->GetURL().spec());
+ CHECK_EQ(entry, new_entry);
}
if (page_state == entry->GetPageState())
@@ -4069,7 +4087,28 @@ void WebContentsImpl::UpdateTitle(RenderFrameHost* render_frame_host,
static_cast<RenderViewHostImpl*>(render_frame_host->GetRenderViewHost());
NavigationEntryImpl* new_entry = controller_.GetEntryWithUniqueID(
rvhi->nav_entry_id());
- DCHECK_EQ(entry, new_entry);
+
+ base::debug::SetCrashKeyValue("pageid", base::IntToString(page_id));
+ base::debug::SetCrashKeyValue("navuniqueid",
+ base::IntToString(rvhi->nav_entry_id()));
+ base::debug::SetCrashKeyValue(
+ "oldindex", base::IntToString(controller_.GetIndexOfEntry(entry)));
+ base::debug::SetCrashKeyValue(
+ "newindex", base::IntToString(controller_.GetIndexOfEntry(new_entry)));
+ base::debug::SetCrashKeyValue(
+ "lastcommittedindex",
+ base::IntToString(controller_.GetLastCommittedEntryIndex()));
+ base::debug::SetCrashKeyValue("oldurl",
+ entry ? entry->GetURL().spec() : "-nullptr-");
+ base::debug::SetCrashKeyValue(
+ "newurl", new_entry ? new_entry->GetURL().spec() : "-nullptr-");
+ base::debug::SetCrashKeyValue("updatedvalue", base::UTF16ToUTF8(title));
+ base::debug::SetCrashKeyValue(
+ "oldvalue", entry ? base::UTF16ToUTF8(entry->GetTitle()) : "-nullptr-");
+ base::debug::SetCrashKeyValue(
+ "newvalue",
+ new_entry ? base::UTF16ToUTF8(new_entry->GetTitle()) : "-nullptr-");
+ CHECK_EQ(entry, new_entry);
// We can handle title updates when we don't have an entry in
// UpdateTitleForEntry, but only if the update is from the current RVH.
« no previous file with comments | « chrome/common/crash_keys.cc ('k') | content/public/common/page_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698