Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Side by Side Diff: chrome/common/crash_keys.cc

Issue 1263393002: Gather debugging information for the switch away from page id for titles and state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pageid Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/crash_keys.h" 5 #include "chrome/common/crash_keys.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/format_macros.h" 8 #include "base/format_macros.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/strings/string_split.h" 10 #include "base/strings/string_split.h"
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 { "rwhvm_window", kMediumSize }, 192 { "rwhvm_window", kMediumSize },
193 // media/: 193 // media/:
194 { "VideoCaptureDeviceQTKit", kSmallSize }, 194 { "VideoCaptureDeviceQTKit", kSmallSize },
195 #endif 195 #endif
196 #if defined(KASKO) 196 #if defined(KASKO)
197 { kKaskoGuid, kSmallSize }, 197 { kKaskoGuid, kSmallSize },
198 { kKaskoEquivalentGuid, kSmallSize }, 198 { kKaskoEquivalentGuid, kSmallSize },
199 #endif 199 #endif
200 { kBug464926CrashKey, kSmallSize }, 200 { kBug464926CrashKey, kSmallSize },
201 { kViewCount, kSmallSize }, 201 { kViewCount, kSmallSize },
202
203 // Temporary for http://crbug.com/369661
204 { "pageid", kSmallSize },
205 { "navuniqueid", kSmallSize },
206 { "oldindex", kSmallSize },
207 { "newindex", kSmallSize },
208 { "lastcommittedindex", kSmallSize },
209 { "oldurl", kLargeSize },
210 { "newurl", kLargeSize },
211 { "updatedvalue", kLargeSize },
212 { "oldvalue", kLargeSize },
213 { "newvalue", kLargeSize },
214 // End http://crbug.com/369661
202 }; 215 };
203 216
204 // This dynamic set of keys is used for sets of key value pairs when gathering 217 // This dynamic set of keys is used for sets of key value pairs when gathering
205 // a collection of data, like command line switches or extension IDs. 218 // a collection of data, like command line switches or extension IDs.
206 std::vector<base::debug::CrashKey> keys( 219 std::vector<base::debug::CrashKey> keys(
207 fixed_keys, fixed_keys + arraysize(fixed_keys)); 220 fixed_keys, fixed_keys + arraysize(fixed_keys));
208 221
209 // Register the switches. 222 // Register the switches.
210 { 223 {
211 // The fixed_keys names are string constants. Use static storage for 224 // The fixed_keys names are string constants. Use static storage for
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
445 } 458 }
446 459
447 ScopedPrinterInfo::~ScopedPrinterInfo() { 460 ScopedPrinterInfo::~ScopedPrinterInfo() {
448 for (size_t i = 0; i < kPrinterInfoCount; ++i) { 461 for (size_t i = 0; i < kPrinterInfoCount; ++i) {
449 std::string key = base::StringPrintf(kPrinterInfo, i + 1); 462 std::string key = base::StringPrintf(kPrinterInfo, i + 1);
450 base::debug::ClearCrashKey(key); 463 base::debug::ClearCrashKey(key);
451 } 464 }
452 } 465 }
453 466
454 } // namespace crash_keys 467 } // namespace crash_keys
OLDNEW
« no previous file with comments | « no previous file | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698