Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1263373002: Perform full GC in background idle notification. (Closed)

Created:
5 years, 4 months ago by ulan
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Perform full GC in background idle notification. BUG=chromium:515873 LOG=NO Committed: https://crrev.com/9aff1d352d772ddcca8d317c31d6ced895bf115c Cr-Commit-Position: refs/heads/master@{#29996}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment #

Patch Set 3 : Guard full gc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M src/heap/memory-reducer.cc View 1 2 1 chunk +14 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ulan
PTAL
5 years, 4 months ago (2015-08-03 17:37:40 UTC) #2
Hannes Payer (out of office)
LGTM https://codereview.chromium.org/1263373002/diff/1/src/heap/memory-reducer.cc File src/heap/memory-reducer.cc (right): https://codereview.chromium.org/1263373002/diff/1/src/heap/memory-reducer.cc#newcode98 src/heap/memory-reducer.cc:98: heap()->CollectAllGarbage(Heap::kReduceMemoryFootprintMask, Let's leave a comment here why we ...
5 years, 4 months ago (2015-08-03 19:11:39 UTC) #3
ulan
Added TODO and added a check for last GC time. https://codereview.chromium.org/1263373002/diff/1/src/heap/memory-reducer.cc File src/heap/memory-reducer.cc (right): https://codereview.chromium.org/1263373002/diff/1/src/heap/memory-reducer.cc#newcode98 ...
5 years, 4 months ago (2015-08-04 11:26:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263373002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263373002/40001
5 years, 4 months ago (2015-08-04 12:07:07 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-04 12:41:59 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 12:42:16 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9aff1d352d772ddcca8d317c31d6ced895bf115c
Cr-Commit-Position: refs/heads/master@{#29996}

Powered by Google App Engine
This is Rietveld 408576698