Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1263363002: Fix presubmit errors in runtime-simd.cc. (Closed)

Created:
5 years, 4 months ago by titzer
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix presubmit errors in runtime-simd.cc. R=mstarzinger@chromium.org BUG= NOTREECHECKS=true Committed: https://crrev.com/80efc9d2fbff2a8d0a6e2c0c6cbc0fa7f9a14119 Cr-Commit-Position: refs/heads/master@{#29977}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M src/runtime/runtime-simd.cc View 4 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
titzer
5 years, 4 months ago (2015-08-03 13:51:23 UTC) #1
Michael Starzinger
LGTM.
5 years, 4 months ago (2015-08-03 13:54:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263363002/1
5 years, 4 months ago (2015-08-03 13:55:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263363002/1
5 years, 4 months ago (2015-08-03 14:26:13 UTC) #7
bbudge-google
LGTM Thanks for fixing this.
5 years, 4 months ago (2015-08-03 14:26:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-03 14:27:58 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 14:28:17 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/80efc9d2fbff2a8d0a6e2c0c6cbc0fa7f9a14119
Cr-Commit-Position: refs/heads/master@{#29977}

Powered by Google App Engine
This is Rietveld 408576698