Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1263353004: Fix non-working battery status manager on Linux. (Closed)

Created:
5 years, 4 months ago by joachim
Modified:
5 years, 4 months ago
Reviewers:
timvolodine
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix non-working battery status manager on Linux. The change in https://crrev.com/2438a3e2acb1318a4e59c78764b532bac3649161 removed the call to start the notification thread and instead always returned "false". This CL fixes this by starting the thread (and thus actually getting status changes). BUG=420623 R=timvolodine@chromium.org Committed: https://crrev.com/6571bc9c6dbc7486326f26292a5e351b938d18a7 Cr-Commit-Position: refs/heads/master@{#342343}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M device/battery/battery_status_manager_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
joachim
ptal
5 years, 4 months ago (2015-08-04 12:34:43 UTC) #1
timvolodine
On 2015/08/04 12:34:43, joachim wrote: > ptal thanks joachim, good catch! must have been a ...
5 years, 4 months ago (2015-08-07 12:55:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263353004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263353004/1
5 years, 4 months ago (2015-08-07 12:59:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 13:39:30 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 13:40:09 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6571bc9c6dbc7486326f26292a5e351b938d18a7
Cr-Commit-Position: refs/heads/master@{#342343}

Powered by Google App Engine
This is Rietveld 408576698