Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1263343002: Revert of Reland concurrent sweeping of code space. (Closed)

Created:
5 years, 4 months ago by Hannes Payer (out of office)
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland concurrent sweeping of code space. (patchset #6 id:100001 of https://codereview.chromium.org/1242333002/) Reason for revert: Reverted because 507840 came back on recent Chromecrash. Should not have committed this Cl. Original issue's description: > Reland concurrent sweeping of code space. > > BUG= > > Committed: https://crrev.com/8516dccf6a561020441773c93c564dd4aa6ee59e > Cr-Commit-Position: refs/heads/master@{#29967} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/5c6e7d00438cc82a5584e3178d7dadf36e4a34f8 Cr-Commit-Position: refs/heads/master@{#29975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -93 lines) Patch
M src/frames.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M src/heap/mark-compact.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 11 chunks +28 lines, -77 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/store-buffer.cc View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hannes Payer (out of office)
Created Revert of Reland concurrent sweeping of code space.
5 years, 4 months ago (2015-08-03 13:06:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263343002/1
5 years, 4 months ago (2015-08-03 13:06:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-03 13:06:48 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5c6e7d00438cc82a5584e3178d7dadf36e4a34f8 Cr-Commit-Position: refs/heads/master@{#29975}
5 years, 4 months ago (2015-08-03 13:07:05 UTC) #4
Hannes Payer (out of office)
5 years, 4 months ago (2015-08-03 14:11:57 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1271773002/ by hpayer@chromium.org.

The reason for reverting is: Bogus revert..

Powered by Google App Engine
This is Rietveld 408576698