Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1263313003: Oilpan: lazily create SelfKeepAlive<>'s persistent reference. (Closed)

Created:
5 years, 4 months ago by sof
Modified:
5 years, 4 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: lazily create SelfKeepAlive<>'s persistent reference. To reduce overhead of having to register a Persistent<> that may only have a non-null reference for a shorter interval, instantiate the Persistent<> on assignment. And clear it out completely when the SelfKeepAlive<> is cleared. R=haraken BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200028

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M Source/platform/heap/Handle.h View 1 chunk +21 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look. having a smaller persistent root set is in our interest, so ...
5 years, 4 months ago (2015-08-04 21:06:18 UTC) #2
haraken
LGTM
5 years, 4 months ago (2015-08-04 23:16:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263313003/1
5 years, 4 months ago (2015-08-05 05:09:42 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 06:04:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200028

Powered by Google App Engine
This is Rietveld 408576698