Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 12633012: Linux: use -Wl,--no-as-needed on 32-bit builders. (Closed)

Created:
7 years, 9 months ago by Paweł Hajdan Jr.
Modified:
7 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Linux: use -Wl,--no-as-needed on 32-bit builders. This is needed to fix a linking error on Ubuntu Precise: /usr/bin/ld: out/Debug/obj.target/sync/libsync.so: undefined reference to symbol 'SSL_ExportKeyingMaterial' /usr/bin/ld: note: 'SSL_ExportKeyingMaterial' is defined in DSO out/Debug/obj.target/net/third_party/nss/libcrssl.so so try adding it to the linker command line out/Debug/obj.target/net/third_party/nss/libcrssl.so: could not read symbols: Invalid operation collect2: ld returned 1 exit status make: *** [out/Debug/unit_tests] Error 1 TBR=thestig BUG=170262 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187181

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Paweł Hajdan Jr.
Committed patchset #1 manually as r187181.
7 years, 9 months ago (2013-03-10 03:07:49 UTC) #1
Paweł Hajdan Jr.
TBR
7 years, 9 months ago (2013-03-10 03:32:37 UTC) #2
Lei Zhang
https://codereview.chromium.org/12633012/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/12633012/diff/1/build/common.gypi#newcode2539 build/common.gypi:2539: ['OS=="linux" and target_arch=="ia32"', { This should be conditioned on ...
7 years, 9 months ago (2013-03-12 01:19:22 UTC) #3
Nico
On 2013/03/12 01:19:22, Lei Zhang wrote: > https://codereview.chromium.org/12633012/diff/1/build/common.gypi > File build/common.gypi (right): > > https://codereview.chromium.org/12633012/diff/1/build/common.gypi#newcode2539 ...
7 years, 8 months ago (2013-04-22 22:13:37 UTC) #4
Lei Zhang
7 years, 8 months ago (2013-04-22 22:28:04 UTC) #5
Message was sent while issue was closed.
On 2013/04/22 22:13:37, Nico wrote:
> On 2013/03/12 01:19:22, Lei Zhang wrote:
> > https://codereview.chromium.org/12633012/diff/1/build/common.gypi
> > File build/common.gypi (right):
> > 
> >
https://codereview.chromium.org/12633012/diff/1/build/common.gypi#newcode2539
> > build/common.gypi:2539: ['OS=="linux" and target_arch=="ia32"', {
> > This should be conditioned on linux_use_gold_binary, rather than by
> > OS/target_arch.
> > 
> > This is also needed in release builds, but we may not have a bot that builds
> > that configuration. Perhaps the right condition is:
> > 
> > linux_use_gold_binary==1 and component=="shared_library"
> 
> ^ Pawel, can you address this? I was confused by the current condition today.

https://codereview.chromium.org/13916007/ but I probably need to test it a bit
more.

Powered by Google App Engine
This is Rietveld 408576698