Issue 12633: * Added new regexp source files to VS project.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12633: * Added new regexp source files to VS project. (Closed)

Created:
12 years ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse, Christian Plesner Hansen

CC:
v8-dev

Visibility:
Public.

Description

New regexp files are now included in VS project.

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -2 lines)			Patch
	M	src/regexp-macro-assembler-ia32.cc	View		2 chunks	+1 line, -2 lines	2 comments	Download
	M	tools/visual_studio/v8_base.vcproj	View		4 chunks	+52 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

Lgtm http://codereview.chromium.org/12633/diff/1/2 File src/regexp-macro-assembler-ia32.cc (left): http://codereview.chromium.org/12633/diff/1/2#oldcode1 Line 1: // Copyright 2008 the V8 project authors. ...

12 years ago (2008-11-25 12:02:06 UTC) #2

Søren Thygesen Gjesse

LGTM I guess there is no bytecodes-irregexp.cc file to match the bytecodes-irregexp.h file.

12 years ago (2008-11-25 12:16:10 UTC) #3

Lasse Reichstein

12 years ago (2008-11-25 14:21:39 UTC) #4

http://codereview.chromium.org/12633/diff/1/2
File src/regexp-macro-assembler-ia32.cc (left):

http://codereview.chromium.org/12633/diff/1/2#oldcode1
Line 1: // Copyright 2008 the V8 project authors. All rights reserved.
Yes, it's a mistake.
Thanks for the tip on how to show colorized diffs.

Expand Messages | Collapse Messages