Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1263273003: Strict Overflow Prevention video_capture_oracle.cc (Closed)

Created:
5 years, 4 months ago by esum
Modified:
5 years, 4 months ago
Reviewers:
miu
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org, erickung1, lcwu1, gfhuang
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Strict Overflow Prevention video_capture_oracle.cc Adding check to video_capture_oracle.cc that prevents strict overflow warning/error. BUG= Committed: https://crrev.com/916455eb7da1baf9d50ebe0400b086a3d795a09b Cr-Commit-Position: refs/heads/master@{#341808}

Patch Set 1 #

Patch Set 2 : Minor change to match old conditions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M media/capture/content/video_capture_oracle.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
esum
Hi Yuri, Thank you again for your help yesterday. I consulted erickung@ and lcwu@ (cc'd) ...
5 years, 4 months ago (2015-08-04 15:03:31 UTC) #2
miu
lgtm. I suppose all this really means I should have made frame_number an unsigned type. ...
5 years, 4 months ago (2015-08-04 20:40:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263273003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263273003/20001
5 years, 4 months ago (2015-08-04 20:42:04 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-04 22:11:57 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 22:12:28 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/916455eb7da1baf9d50ebe0400b086a3d795a09b
Cr-Commit-Position: refs/heads/master@{#341808}

Powered by Google App Engine
This is Rietveld 408576698